Skip to content

Allow to append (instead of prepend) Propagation::SqlComment comment聽#3601

Closed

Description

@beauraF

Hello 馃憢

When database monitoring is enable, and propagation mode is set to full or service, ddtrace is prepending a comment to each SQL query.

https://github.com/DataDog/dd-trace-rb/blob/master/lib/datadog/tracing/contrib/propagation/sql_comment.rb

While we understand the value of having them prefixed, this comes with the drawbacks of breaking query preview of other monitoring tool like AWS Performance Insights.

Would it be possible to expose a configuration in order to opt for suffixing instead of prefixing?
Note that we maintain a patch on our side to handle this, and Database Monitoring still behaves correctly.

Activity

  1. added
    communityWas opened by a community member
    feature-requestA request for a new feature or change to an existing one
    on Apr 19, 2024
  2. changed the title [-]Allow to suffix (instead of prepend) `Propagation::SqlComment` comment[/-] [+]Allow to append (instead of prepend) `Propagation::SqlComment` comment[/+] on Apr 19, 2024
  3. added
    bugInvolves a bug
    feature-requestA request for a new feature or change to an existing one
    dbmDatabase Monitoring product
    and removed
    feature-requestA request for a new feature or change to an existing one
    on Apr 19, 2024
  4. dujuku commented on Apr 25, 2024

    @dujuku

    Hi @beauraF! Thanks for bringing this to our attention. I've made a note of this internally, but I would suggest opening a feature request with Datadog Support as well so we have a record tied to your account. I'll discuss this with the engineering team on how we want to approach this.

    I'm going to close this issue for now. By opening a feature request with support, you will also be notified of any updates.

  5. marcotc commented on Jul 25, 2024

    @marcotc
    Member

    We are adding this option in #3809

  6. self-assigned this
    on Jul 25, 2024
  7. TonyCTHsu commented on Aug 22, 2024

    @TonyCTHsu
    Collaborator

    馃憢 @beauraF 2.3.0 is released, give it a try!

  8. beauraF commented on Sep 4, 2024

    @beauraF
    Author

    Thanks @TonyCTHsu! Works great 馃檹

  9. added this to the 2.3.0 milestone on Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugInvolves a bugcommunityWas opened by a community memberdbmDatabase Monitoring product

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions