Open
Description
openedon Feb 7, 2024
Current behaviour
When initializing sidekiq instrumentation with a custom service_name
setting, all operations
seem to get tagged with that service name, except sidekiq.push
which seems to get tagged with the default DD_SERVICE
env var.
Expected behaviour
All operations should get tagged with the service_name
provided if supplied.
Steps to reproduce
Datadog.configure do |c|
c.tracing.instrument :sidekiq, service_name: 'my-custom-service'
end
I already looked and I can see that sidekiq.push
is pulling its service tag from a totally other config setting called client_service_name. But why?
This client_service_name
option isn't documented. And it doesn't seem to be a common pattern by my searching so why the inconsistency?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment