Skip to content

Exceptions captured with rescue_from :all still appear in Error Tracking when using Grape integration #3253

Open

Description

Expected behavior

When using Grape's rescue_from :all to capture exceptions, I expect these exceptions to be handled internally and not to appear in Datadog's Error Tracking.

Actual behavior
Despite using rescue_from :all, exceptions are still being sent to Datadog's Error Tracking. It seems that the error is assigned to the span before the rescue_from block is called, so the error still appears in the Error Tracking dashboard.

Additional context

If Grape's instrumentation is removed, the context in rack spans is lost, e.g.:

with Grape's instrumentation:
Screenshot 2023-11-10 at 16 29 10

without Grape's instrumentation:
Screenshot 2023-11-10 at 16 30 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

bugInvolves a bugcommunityWas opened by a community member

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions