Skip to content

Commit

Permalink
[active_record] add standalone test for ActiveRecord
Browse files Browse the repository at this point in the history
  • Loading branch information
Emanuele Palazzetti committed Jan 26, 2018
1 parent 65019a0 commit 4e94e37
Show file tree
Hide file tree
Showing 5 changed files with 74 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ if RUBY_VERSION >= '2.2.2' && RUBY_PLATFORM != 'java'
gem 'dalli'
gem 'resque', '< 2.0'
gem 'racecar', '>= 0.3.5'
gem 'mysql2', platform: :ruby
end
else
appraise 'contrib-old' do
Expand All @@ -146,5 +147,6 @@ else
gem 'sucker_punch'
gem 'dalli'
gem 'resque', '< 2.0'
gem 'mysql2', platform: :ruby
end
end
3 changes: 3 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ namespace :spec do
:mongodb,
:racecar,
:resque,
:active_record,
:dalli
].each do |contrib|
RSpec::Core::RakeTask.new(contrib) do |t|
Expand Down Expand Up @@ -220,9 +221,11 @@ task :ci do
sh 'rvm $MRI_OLD_VERSIONS --verbose do appraisal contrib-old rake test:sucker_punch'
sh 'rvm $MRI_OLD_VERSIONS --verbose do appraisal contrib-old rake test:resque'
# RSpec
sh 'rvm $MRI_VERSIONS --verbose do appraisal contrib rake spec:active_record'
sh 'rvm $MRI_VERSIONS --verbose do appraisal contrib rake spec:dalli'
sh 'rvm $MRI_VERSIONS --verbose do appraisal contrib rake spec:racecar'
sh 'rvm $MRI_OLD_VERSIONS --verbose do appraisal contrib-old rake spec:dalli'
sh 'rvm $MRI_OLD_VERSIONS --verbose do appraisal contrib-old rake spec:active_record'
when 2
sh 'rvm $MRI_VERSIONS --verbose do appraisal contrib rake test:sidekiq'
sh 'rvm $SIDEKIQ_OLD_VERSIONS --verbose do appraisal contrib-old rake test:sidekiq'
Expand Down
1 change: 1 addition & 0 deletions gemfiles/contrib.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ gem "sucker_punch"
gem "dalli"
gem "resque", "< 2.0"
gem "racecar", ">= 0.3.5"
gem "mysql2", platform: :ruby

gemspec path: "../"
36 changes: 36 additions & 0 deletions spec/ddtrace/contrib/active_record/app.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
require 'active_record'
require 'mysql2'

logger = Logger.new(STDOUT)
logger.level = Logger::INFO

# connecting to any kind of database is enough to test the integration
ActiveRecord::Base.establish_connection('mysql2://root:root@127.0.0.1:53306/mysql')

class ApplicationRecord < ActiveRecord::Base
self.abstract_class = true
end

class Article < ApplicationRecord
end

# check if the migration has been executed
# MySQL JDBC drivers require that, otherwise we get a
# "Table '?' already exists" error
begin
Article.count()
rescue ActiveRecord::StatementInvalid
logger.info 'Executing database migrations'
ActiveRecord::Schema.define(version: 20161003090450) do
create_table 'articles', force: :cascade do |t|
t.string 'title'
t.datetime 'created_at', null: false
t.datetime 'updated_at', null: false
end
end
else
logger.info 'Database already exists; nothing to do'
end

# force an access to prevent extra spans during tests
Article.count()
32 changes: 32 additions & 0 deletions spec/ddtrace/contrib/active_record/tracer_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
require 'spec_helper'
require 'ddtrace'

require_relative 'app'

RSpec.describe 'Dalli instrumentation' do
let(:tracer) { ::Datadog::Tracer.new(writer: FauxWriter.new) }

before(:each) do
Datadog.configure do |c|
c.use :active_record, tracer: tracer
end
end

it 'calls the instrumentation when is used standalone' do
Article.count
spans = tracer.writer.spans
expect(spans.size).to eq(1)

span = spans[0]
expect(span.service).to eq('mysql2')
expect(span.name).to eq('mysql2.query')
expect(span.span_type).to eq('sql')
expect(span.resource).to eq('SELECT COUNT(*) FROM `articles`')
expect(span.get_tag('active_record.db.vendor')).to eq('mysql2')
expect(span.get_tag('active_record.db.name')).to eq('mysql')
expect(span.get_tag('active_record.db.cached')).to eq(nil)
expect(span.get_tag('out.host')).to eq('127.0.0.1')
expect(span.get_tag('out.port')).to eq('53306')
expect(span.get_tag('sql.query')).to eq(nil)
end
end

0 comments on commit 4e94e37

Please sign in to comment.