Skip to content

Commit

Permalink
Remove maximum resque version support (#1761)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcotc authored Nov 5, 2021
1 parent a1d917b commit 1217a07
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
6 changes: 1 addition & 5 deletions lib/ddtrace/contrib/resque/integration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class Integration
include Contrib::Integration

MINIMUM_VERSION = Gem::Version.new('1.0')
# Maximum is first version it's NOT compatible with (not inclusive)
MAXIMUM_VERSION = Gem::Version.new('3.0')

register_as :resque, auto_patch: true

Expand All @@ -25,9 +23,7 @@ def self.loaded?
end

def self.compatible?
super \
&& version >= MINIMUM_VERSION \
&& version < MAXIMUM_VERSION
super && version >= MINIMUM_VERSION
end

def default_configuration
Expand Down
5 changes: 0 additions & 5 deletions spec/ddtrace/contrib/resque/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@
include_context 'loaded gems', resque: described_class::MINIMUM_VERSION
it { is_expected.to be true }
end

context 'that exceeds the maximum version' do
include_context 'loaded gems', resque: described_class::MAXIMUM_VERSION
it { is_expected.to be false }
end
end

context 'when gem is not loaded' do
Expand Down

0 comments on commit 1217a07

Please sign in to comment.