Merged
Conversation
this function does c-level checks of the type of the argument so it must be a raw psycopg connection passed in. this adds a hook to transparently downgrade.
clutchski
commented
Nov 7, 2016
| name = _get_vendor(conn) | ||
| self._datadog_pin = Pin(service=name, app=name) | ||
|
|
||
| def execute(self, *args, **kwargs): |
Contributor
Author
There was a problem hiding this comment.
will move this to a sqlite specific class. it was breaking this test:
Contributor
There was a problem hiding this comment.
Is that possible that this shared pdbapi will break again? Should we move it all to lib-specific contrib? (even if it implies code duplication).
Contributor
Author
There was a problem hiding this comment.
yea it's an option. i want to experiment with this a bit though.
This was referenced Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_typeperforms c-level type checks of connections, so we need to be sure to transparently downgrade passed in connections.needs to be patched globally even if we are wrapping a single connection.