Skip to content

Comments

[psycopg2] add support for version 2.4#424

Merged
palazzem merged 1 commit intomasterfrom
palazzem/psycopg-extension
Feb 23, 2018
Merged

[psycopg2] add support for version 2.4#424
palazzem merged 1 commit intomasterfrom
palazzem/psycopg-extension

Conversation

@palazzem
Copy link

Overview

psycopg2 version 2.4 wasn't tested in our test matrix. The PR #393 added patches for all imports of register_type, causing an import error for psycopg2==2.4 (_json attribute isn't available). Because of that, the patching safe-guard, disables psycopg2 integration.

This patch adds version 2.4 to our test matrix and disables _json patching since it's not available for that version.

@palazzem palazzem added this to the 0.11.0 milestone Feb 23, 2018
@palazzem palazzem requested a review from LotharSee February 23, 2018 14:57
Copy link
Contributor

@LotharSee LotharSee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM.

@palazzem palazzem merged commit 9ffb621 into master Feb 23, 2018
@palazzem palazzem deleted the palazzem/psycopg-extension branch February 23, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants