-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Fix CI Visibility Spec Tests #2885
Conversation
@juan-fernandez can you add a changelog entry(ies) for this PR? |
sure, will do 👍 |
added it! |
sanic tests are failing, but they seem to be flakes |
@juan-fernandez yeah sanic is failing unrelated, due to a new release. Working on a fix for it! |
does it look good otherwise @brettlangdon ? |
Codecov Report
@@ Coverage Diff @@
## master #2885 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 599 599
Lines 44315 44315
=======================================
Hits 37529 37529
Misses 6786 6786
Continue to review full report at Codecov.
|
sanic tests are passing now 👍 |
releasenotes/notes/update-ci-metadata-extraction-1f5c1b2b0da14287.yaml
Outdated
Show resolved
Hide resolved
…287.yaml Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
@Kyle-Verhoog maybe you can have a look too? The PR needs 2 approving reviews |
Description
usersupplied.json
as fixture (for user defined git metadata).Context: DataDog/dd-trace-rb#1687
Checklist