Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix CI Visibility Spec Tests #2885

Merged
merged 8 commits into from
Oct 5, 2021

Conversation

juan-fernandez
Copy link
Contributor

@juan-fernandez juan-fernandez commented Sep 30, 2021

Description

  • Fix branch extraction in gitlab.
  • Add stage and job name in azure pipelines.
  • Add usersupplied.json as fixture (for user defined git metadata).
  • Fix spec tests.

Context: DataDog/dd-trace-rb#1687

Checklist

  • Added to the correct milestone.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Library documentation is updated.
  • Corp site documentation is updated (link to the PR).

@juan-fernandez juan-fernandez requested a review from a team as a code owner September 30, 2021 13:03
@brettlangdon
Copy link
Member

@juan-fernandez can you add a changelog entry(ies) for this PR?

@juan-fernandez
Copy link
Contributor Author

@juan-fernandez can you add a changelog entry(ies) for this PR?

sure, will do 👍

@juan-fernandez
Copy link
Contributor Author

@juan-fernandez can you add a changelog entry(ies) for this PR?

sure, will do 👍

added it!

@juan-fernandez
Copy link
Contributor Author

sanic tests are failing, but they seem to be flakes

@Kyle-Verhoog
Copy link
Member

@juan-fernandez yeah sanic is failing unrelated, due to a new release. Working on a fix for it!

@juan-fernandez
Copy link
Contributor Author

does it look good otherwise @brettlangdon ?

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #2885 (0db7e0f) into master (4c89ecf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2885   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files         599      599           
  Lines       44315    44315           
=======================================
  Hits        37529    37529           
  Misses       6786     6786           
Impacted Files Coverage Δ
ddtrace/ext/ci.py 62.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c89ecf...0db7e0f. Read the comment docs.

@juan-fernandez
Copy link
Contributor Author

sanic tests are passing now 👍

…287.yaml

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
@juan-fernandez
Copy link
Contributor Author

@Kyle-Verhoog maybe you can have a look too? The PR needs 2 approving reviews

@mergify mergify bot merged commit 3e52513 into master Oct 5, 2021
@mergify mergify bot deleted the juan-fernandez/update-ci-app-spec branch October 5, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants