Repository navigation
fix(config): support OTel deployment environment name - #19901
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
Codeowners resolved asResolved from the full PR diff against No remaining files require a CODEOWNERS review. |
Circular import analysis
|
Dependency direction analysis
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6827a180f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🎉 All green!🧪 All tests passed 🔗 Commit SHA: f3c41be | Docs | View more details | Give us feedback! |
a6827a1 to
f3c41be
Compare
## Summary of changes Map `deployment.environment.name` to the Datadog environment. Keep `deployment.environment` as a fallback, and keep `DD_ENV` as the highest-precedence source. ## Reason for change OpenTelemetry stabilized the deployment environment semantic convention under `deployment.environment.name`. Related PRs: - DataDog/system-tests#7613 - DataDog/dd-trace-go#5285 - #9150 - DataDog/dd-trace-rb#6261 - DataDog/dd-trace-php#4148 - DataDog/dd-trace-js#10050 - DataDog/dd-trace-rs#300 - DataDog/dd-trace-java#12324 - DataDog/dd-trace-py#19901 ## Implementation details The resource attribute mapper tracks the stable and legacy values separately, then chooses the stable value regardless of input order. It removes both source aliases after promotion and leaves unrelated attributes alone. ## Test coverage Five focused mapping cases and 182 adjacent configuration tests passed locally. Formatting checks also passed. ## Other details None. --------- Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
Description
Maps the stable OpenTelemetry
deployment.environment.nameresource attribute to the Datadog environment. The deprecateddeployment.environmentattribute remains supported as a fallback.This ensures applications using the current OpenTelemetry semantic convention receive the expected unified environment tag.
Testing
scripts/lint checksRisks
Low. The change adds an alias to the existing resource attribute remapping and preserves legacy behavior.
Additional Notes
Includes a customer-facing release note under the
tracingscope.