Repository navigation
fix(native): bump libdatadog to v36 - #18713
Closed
VianneyRuhlmann wants to merge 4 commits into
Closed
VianneyRuhlmann wants to merge 4 commits into
VianneyRuhlmann wants to merge 4 commits into
Conversation
Contributor
|
VianneyRuhlmann
added
the
changelog/no-changelog
Codeowners resolved as |
BenchmarksBenchmark execution time: 2026-06-24 11:39:58 Comparing candidate commit 92096b1 in PR branch Found 0 performance improvements and 8 performance regressions! Performance is the same for 608 metrics, 10 unstable metrics. scenario:iast_aspects-re_expand_aspect
scenario:iast_aspects-re_search_aspect
scenario:iastaspects-strip_aspect
scenario:iastaspects-upper_noaspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
scenario:tracer-small
|
## Motivation PR #18713 bumps libdatadog to v36. System Tests fail because invalid Feature Flagging and Experimentation flag configuration now comes through libdatadog as `FlagConfigurationInvalid`; dd-trace-py previously fell through to OpenFeature `GENERAL`, causing metrics to emit `error.type:general` instead of the expected `error.type:parse_error`. ## Changes This maps `EvaluationError::FlagConfigurationInvalid` to the existing native `ParseError` wrapper path alongside `ConfigurationParseError`. It also adds an OpenFeature provider regression test for invalid per-flag configuration and a release note for the preserved error-code behavior. ## Decisions The fix stays in the Rust/PyO3 wrapper rather than changing Python metrics code or system-test expectations, because the upstream native error still represents an invalid flag configuration parse/compile failure. This PR is stacked on `vianney/bump-libdatadog-36` so the libdatadog upgrade can absorb the compatibility shim directly. ## Testing - `scripts/lint fmt tests/openfeature/test_provider.py` - `cargo fmt --manifest-path src/native/Cargo.toml -- src/native/ffe.rs` - `scripts/lint style tests/openfeature/test_provider.py` - `scripts/run-tests --venv 13c4b39 tests/openfeature/test_provider.py -- -- -k invalid_configuration -vv` - `uvx --from reno reno lint` ## Risks Low. The change only maps a newly introduced libdatadog v36 FFE error variant to the same OpenFeature parse error already used for configuration parse failures.
mabdinur
approved these changes
Jun 23, 2026
mabdinur
reviewed
Jun 23, 2026
VianneyRuhlmann
marked this pull request as ready for review
June 24, 2026 07:58
VianneyRuhlmann
requested review from
juanjux,
leoromanovsky,
sabrenner and
typotter
June 24, 2026 07:58
VianneyRuhlmann
removed
the
changelog/no-changelog
iunanua
reviewed
Jun 24, 2026
leoromanovsky
approved these changes
Jun 24, 2026
VianneyRuhlmann
changed the title
emmettbutler
approved these changes
Jul 1, 2026
Contributor
|
Would it make sense to merge this PR instead: #18821? Then we can bump dd-trace-py straight to v37 rather than v36. |
Contributor
Author
|
Closed in favor of #18821 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump libdatadog to v36.0.0