Skip to content

chore(llmobs): move agent manifest to _dd field - #16621

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits into
mainfrom
nicole-cybul/move-agent-manifest
Mar 2, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 8 commits into
mainfrom
nicole-cybul/move-agent-manifest

Conversation

@ncybul

@ncybul ncybul commented Feb 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR nests the agent manifest under the _dd field within the metadata which will be filtered out on the FE. The goal is to move all fields that are internally used to this nested scope to avoid clashing with user-submitted metadata.

Corresponding PR to update the FE to check for the agent manifest under this new scope.

Testing

Risks

Additional Notes

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Feb 20, 2026 •

Copy link
Copy Markdown

Codeowners resolved as

.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/llmobs/_integrations/claude_agent_sdk.py                        @DataDog/ml-observability
ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability
tests/contrib/claude_agent_sdk/test_claude_agent_sdk_llmobs.py          @DataDog/ml-observability
tests/contrib/crewai/test_crewai_llmobs.py                              @DataDog/ml-observability
tests/contrib/google_adk/test_google_adk_llmobs.py                      @DataDog/ml-observability
tests/contrib/langgraph/test_langgraph_llmobs.py                        @DataDog/ml-observability
tests/contrib/openai_agents/test_openai_agents_llmobs.py                @DataDog/ml-observability
tests/contrib/pydantic_ai/utils.py                                      @DataDog/ml-observability

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Feb 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2eeb187 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@ncybul ncybul added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 23, 2026
@ncybul
ncybul marked this pull request as ready for review February 23, 2026 09:35
@ncybul
ncybul requested review from a team as code owners February 23, 2026 09:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 930d14a689

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ddtrace/llmobs/_llmobs.py Outdated

@brettlangdon brettlangdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I was pulled as codeowner for: tests/contrib/claude_agent_sdk/test_claude_agent_sdk_llmobs.py

might need to update CODEOWNERS

but regardless, this change lgtm

@ncybul
ncybul requested a review from a team as a code owner February 23, 2026 09:52
@ncybul
ncybul requested a review from RamyElkest February 23, 2026 09:52
@ncybul

ncybul commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 23, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-23 14:37:04 UTC ℹ️ Start processing command /merge


2026-02-23 14:37:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-02-23 18:43:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@ncybul

ncybul commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 27, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-27 12:03:00 UTC ℹ️ Start processing command /merge


2026-02-27 12:03:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 4h (p90).


2026-02-27 12:50:08 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 3721de8:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@ncybul

ncybul commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 27, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-27 12:51:30 UTC ℹ️ Start processing command /merge


2026-02-27 12:51:35 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 4h (p90).


2026-02-27 14:52:22 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 99404035 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

@ncybul

ncybul commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Feb 27, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-02-27 14:56:53 UTC ℹ️ Start processing command /merge


2026-02-27 14:56:58 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 4h (p90).


2026-02-27 16:58:15 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 99435989 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

@ncybul

ncybul commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 2, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-02 15:11:16 UTC ℹ️ Start processing command /merge


2026-03-02 15:11:21 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 4h (p90).


2026-03-02 15:13:13 UTC ⚠️ MergeQueue: This merge request was unqueued

This pull request was closed.

@ncybul ncybul closed this Mar 2, 2026
@ncybul ncybul reopened this Mar 2, 2026
@ncybul

ncybul commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Mar 2, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-02 15:13:30 UTC ℹ️ Start processing command /merge


2026-03-02 15:13:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-03-02 15:50:26 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 4h (p90).


2026-03-02 17:44:20 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 57271f9 into main Mar 2, 2026
546 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the nicole-cybul/move-agent-manifest branch March 2, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants