Repository navigation
chore(llmobs): move agent manifest to _dd field - #16621
Conversation
Codeowners resolved as |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 2eeb187 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 930d14a689
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
brettlangdon
left a comment
There was a problem hiding this comment.
Not sure why I was pulled as codeowner for: tests/contrib/claude_agent_sdk/test_claude_agent_sdk_llmobs.py
might need to update CODEOWNERS
but regardless, this change lgtm
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 3721de8: What to do next?
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 99404035 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 99435989 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This pull request was closed. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
Description
This PR nests the agent manifest under the
_ddfield within the metadata which will be filtered out on the FE. The goal is to move all fields that are internally used to this nested scope to avoid clashing with user-submitted metadata.Corresponding PR to update the FE to check for the agent manifest under this new scope.
Testing
Risks
Additional Notes