-
Notifications
You must be signed in to change notification settings - Fork 476
chore(profiling): we do support gevent
#15799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gevent
Performance SLOsComparing candidate kowalski/chore-profiling-we-do-support-gevent (05c6f98) with baseline main (240abfb) ❌ Test Failures (1 suite)❌ iastaspects - 117/118✅ add_aspectTime: ✅ 17.890µs (SLO: <20.000µs 📉 -10.5%) vs baseline: 📈 +20.3% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 14.941µs (SLO: <20.000µs 📉 -25.3%) vs baseline: +0.1% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -1.0% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.548µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 18.027µs (SLO: <30.000µs 📉 -39.9%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 23.933µs (SLO: <30.000µs 📉 -20.2%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 2.764µs (SLO: <10.000µs 📉 -72.4%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 1.467µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 16.631µs (SLO: <20.000µs 📉 -16.8%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 1.437µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +0.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 55.531µs (SLO: <70.000µs 📉 -20.7%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 3.306µs (SLO: <10.000µs 📉 -66.9%) vs baseline: +0.9% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ capitalize_aspectTime: ✅ 14.717µs (SLO: <20.000µs 📉 -26.4%) vs baseline: +0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 2.567µs (SLO: <10.000µs 📉 -74.3%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 14.627µs (SLO: <20.000µs 📉 -26.9%) vs baseline: +0.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 3.181µs (SLO: <10.000µs 📉 -68.2%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ decode_aspectTime: ✅ 15.599µs (SLO: <30.000µs 📉 -48.0%) vs baseline: -0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 1.583µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -2.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 14.797µs (SLO: <30.000µs 📉 -50.7%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.664µs (SLO: <10.000µs 📉 -83.4%) vs baseline: 📈 +10.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 170.964µs (SLO: <200.000µs 📉 -14.5%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 191.680µs (SLO: <200.000µs -4.2%) vs baseline: +0.4% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 3.814µs (SLO: <10.000µs 📉 -61.9%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 3.150µs (SLO: <10.000µs 📉 -68.5%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 15.293µs (SLO: <20.000µs 📉 -23.5%) vs baseline: -0.6% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 17.182µs (SLO: <20.000µs 📉 -14.1%) vs baseline: +0.2% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ join_noaspectTime: ✅ 1.551µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 20.834µs (SLO: <30.000µs 📉 -30.6%) vs baseline: -0.1% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 2.702µs (SLO: <10.000µs 📉 -73.0%) vs baseline: -0.7% Memory: ✅ 42.487MB (SLO: <43.250MB 🟡 -1.8%) vs baseline: +4.5% ✅ lower_aspectTime: ✅ 17.927µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 2.448µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +0.5% Memory: ✅ 42.703MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.2% ✅ lstrip_aspectTime: ✅ 17.727µs (SLO: <30.000µs 📉 -40.9%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 1.856µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -1.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 166.507µs (SLO: <200.000µs 📉 -16.7%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.268µs (SLO: <200.000µs 📉 -12.9%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 168.554µs (SLO: <200.000µs 📉 -15.7%) vs baseline: -0.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.916µs (SLO: <200.000µs 📉 -14.0%) vs baseline: +0.2% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 3.675µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.4% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 220.160µs (SLO: <300.000µs 📉 -26.6%) vs baseline: +3.7% Memory: ✅ 42.526MB (SLO: <44.000MB -3.3%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 2.914µs (SLO: <10.000µs 📉 -70.9%) vs baseline: +0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 1.426µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.524µs (SLO: <10.000µs 📉 -94.8%) vs baseline: ~same Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 19.008µs (SLO: <30.000µs 📉 -36.6%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 1.943µs (SLO: <10.000µs 📉 -80.6%) vs baseline: +0.7% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 15.827µs (SLO: <20.000µs 📉 -20.9%) vs baseline: -0.3% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.6% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 53.819µs (SLO: <80.000µs 📉 -32.7%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 3.660µs (SLO: <10.000µs 📉 -63.4%) vs baseline: +0.5% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ❌ strip_aspectTime: ❌ 21.718µs (SLO: <20.000µs +8.6%) vs baseline: 📈 +23.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 1.879µs (SLO: <10.000µs 📉 -81.2%) vs baseline: +0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ swapcase_aspectTime: ✅ 18.468µs (SLO: <30.000µs 📉 -38.4%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 3.034µs (SLO: <10.000µs 📉 -69.7%) vs baseline: +8.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 18.294µs (SLO: <30.000µs 📉 -39.0%) vs baseline: +0.6% Memory: ✅ 42.585MB (SLO: <43.000MB 🟡 -1.0%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 2.702µs (SLO: <10.000µs 📉 -73.0%) vs baseline: +1.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 20.642µs (SLO: <30.000µs 📉 -31.2%) vs baseline: +0.3% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 4.356µs (SLO: <10.000µs 📉 -56.4%) vs baseline: +0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 18.043µs (SLO: <30.000µs 📉 -39.9%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 2.442µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.141µs (SLO: <10.000µs 📉 -48.6%) vs baseline: 📈 +21.2% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 4.311µs (SLO: <10.000µs 📉 -56.9%) vs baseline: -0.4% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.238µs (SLO: <10.000µs 📉 -37.6%) vs baseline: +0.6% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 6.296µs (SLO: <10.000µs 📉 -37.0%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.579µs (SLO: <10.000µs 📉 -64.2%) vs baseline: -0.7% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 3.645µs (SLO: <10.000µs 📉 -63.5%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.894µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -1.5% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 5.022µs (SLO: <10.000µs 📉 -49.8%) vs baseline: -0.3% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.727µs (SLO: <10.000µs 📉 -62.7%) vs baseline: ~same Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.751µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +0.9% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.602µs (SLO: <10.000µs 📉 -54.0%) vs baseline: ~same Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 4.656µs (SLO: <10.000µs 📉 -53.4%) vs baseline: +0.1% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.363µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +12.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 198.681µs (SLO: <220.000µs -9.7%) vs baseline: -1.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.294µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -1.1% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.074µs (SLO: <230.000µs -7.4%) vs baseline: -0.7% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.183µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.026µs (SLO: <150.000µs -8.6%) vs baseline: +0.7% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.122µs (SLO: <20.000µs 📉 -84.4%) vs baseline: -0.5% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.532µs (SLO: <250.000µs 📉 -14.6%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.088ms (SLO: <22.000ms -8.7%) vs baseline: ~same Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.212ms (SLO: <2.550ms 📉 -13.2%) vs baseline: -1.2% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.3% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.422ms (SLO: <1.550ms -8.3%) vs baseline: -0.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.4% ✅ 100-rate-metrics-100-timesTime: ✅ 2.215ms (SLO: <2.550ms 📉 -13.1%) vs baseline: +1.8% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ flush-1-metricTime: ✅ 4.562µs (SLO: <20.000µs 📉 -77.2%) vs baseline: +0.3% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 174.086µs (SLO: <250.000µs 📉 -30.4%) vs baseline: -0.3% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.160ms (SLO: <2.500ms 📉 -13.6%) vs baseline: -1.3% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
This removes a misleading comment and improves typing/readability.