Skip to content

test(co): test for all snapshot IDs #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(co): test for all snapshot IDs #15273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions tests/debugging/origin/test_span.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
from pathlib import Path
import typing as t

import pytest

import ddtrace
from ddtrace.debugging._origin.span import SpanCodeOriginProcessorEntry
from ddtrace.debugging._origin.span import SpanCodeOriginProcessorExit
Expand Down Expand Up @@ -47,6 +45,9 @@ def setUp(self):
MockSpanCodeOriginProcessorEntry.enable()
MockSpanCodeOriginProcessor.enable()

if (uploader := MockSpanCodeOriginProcessor.get_uploader()) is not None:
uploader.flush()

def tearDown(self):
ddtrace.tracer = self.backup_tracer
super(SpanProbeTestCase, self).tearDown()
Expand Down Expand Up @@ -94,7 +95,6 @@ def entry_call():
assert _exit.get_tag("_dd.code_origin.frames.0.file") == str(Path(__file__).resolve())
assert _exit.get_tag("_dd.code_origin.frames.0.line") == str(self.test_span_origin.__code__.co_firstlineno)

@pytest.mark.skip(reason="Frequent unreliable failures")
def test_span_origin_session(self):
def entry_call():
pass
Expand All @@ -111,7 +111,12 @@ def entry_call():

self.assert_span_count(3)
entry, middle, _exit = self.get_spans()
payloads = MockSpanCodeOriginProcessor.get_uploader().wait_for_payloads()

snapshot_ids_from_span_tags = {
s.get_tag(f"_dd.code_origin.frames.{_}.snapshot_id") for s in (entry, middle, _exit) for _ in range(8)
} - {None}

payloads = MockSpanCodeOriginProcessor.get_uploader().wait_for_payloads(len(snapshot_ids_from_span_tags))
snapshot_ids = {p["debugger"]["snapshot"]["id"] for p in payloads}

assert len(payloads) == len(snapshot_ids)
Expand All @@ -125,9 +130,8 @@ def entry_call():

# Check that we have all the snapshots for the exit span
assert _exit.get_tag("_dd.code_origin.type") == "exit"
snapshot_ids_from_span_tags = {_exit.get_tag(f"_dd.code_origin.frames.{_}.snapshot_id") for _ in range(8)}
snapshot_ids_from_span_tags.discard(None)
assert snapshot_ids_from_span_tags < snapshot_ids

assert snapshot_ids_from_span_tags == snapshot_ids

# Check that we have complete data
snapshot_ids_from_span_tags.add(entry_snapshot_id)
Expand Down
Loading