-
Notifications
You must be signed in to change notification settings - Fork 468
ci: add namespace package check #15256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
a3c8078 to
ea29f6c
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 258 ± 8 ms. The average import time from base is: 273 ± 8 ms. The import time difference between this PR and base is: -14.3 ± 0.4 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate brettlangdon/check.namespace.packages (4ff9005) with baseline main (3fc3fac) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.1% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.5% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.2% ✅ add_noaspectTime: ✅ 0.274µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -0.6% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.337µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.4% ✅ bytearray_extend_aspectTime: ✅ 1.617µs (SLO: <10.000µs 📉 -83.8%) vs baseline: +6.0% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.615µs (SLO: <10.000µs 📉 -93.9%) vs baseline: +0.6% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.5% ✅ bytearray_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.1% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.404µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +9.7% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ bytesio_aspectTime: ✅ 1.295µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ capitalize_aspectTime: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.3% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.442µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +1.8% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ casefold_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.6% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +3.9% ✅ casefold_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.725µs (SLO: <10.000µs 📉 -92.8%) vs baseline: ~same Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.8% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.4% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.3% ✅ encode_noaspectTime: ✅ 0.398µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.7% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 3.366µs (SLO: <10.000µs 📉 -66.3%) vs baseline: +1.0% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.848µs (SLO: <10.000µs 📉 -61.5%) vs baseline: 📈 +10.4% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 0.777µs (SLO: <10.000µs 📉 -92.2%) vs baseline: ~same Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ format_noaspectTime: ✅ 0.591µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.4% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.4% ✅ index_aspectTime: ✅ 0.362µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.1% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2% Memory: ✅ 39.617MB (SLO: <41.500MB -4.5%) vs baseline: +5.6% ✅ join_aspectTime: ✅ 1.439µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +3.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.514µs (SLO: <20.000µs 📉 -87.4%) vs baseline: +0.3% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.1% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.200µs (SLO: <10.000µs 📉 -78.0%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.1% ✅ lower_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.4% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.5% ✅ lstrip_aspectTime: ✅ 2.476µs (SLO: <20.000µs 📉 -87.6%) vs baseline: 📈 +11.6% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.1% Memory: ✅ 39.617MB (SLO: <41.500MB -4.5%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 1.044µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.534µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -1.3% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 0.980µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -2.1% Memory: ✅ 39.734MB (SLO: <41.500MB -4.3%) vs baseline: +5.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.258µs (SLO: <10.000µs 📉 -87.4%) vs baseline: ~same Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.8% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.908µs (SLO: <10.000µs 📉 -50.9%) vs baseline: +0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.467µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +1.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.2% ✅ repr_aspectTime: ✅ 0.912µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.5% Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.887µs (SLO: <20.000µs 📉 -90.6%) vs baseline: +0.5% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +5.3% ✅ rstrip_noaspectTime: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.7% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.6% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.548µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.6% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +3.8% ✅ stringio_noaspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.8% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.526µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +14.2% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.0% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 2.407µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +0.1% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.7%) vs baseline: ~same Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.331µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +0.7% Memory: ✅ 39.597MB (SLO: <41.500MB -4.6%) vs baseline: +5.3% ✅ title_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 3.227µs (SLO: <10.000µs 📉 -67.7%) vs baseline: +0.4% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.281µs (SLO: <10.000µs 📉 -77.2%) vs baseline: +4.0% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% 🟡 Near SLO Breach (1 suite)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.593ms (SLO: <4.750ms -3.3%) vs baseline: -0.2% Memory: ✅ 64.021MB (SLO: <66.500MB -3.7%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.615ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: ~same Memory: ✅ 64.219MB (SLO: <66.500MB -3.4%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.6% Memory: ✅ 64.006MB (SLO: <66.500MB -3.7%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 47.898MB (SLO: <49.500MB -3.2%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 44.408MB (SLO: <49.000MB -9.4%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.938ms (SLO: <2.100ms -7.7%) vs baseline: +0.7% Memory: ✅ 48.637MB (SLO: <50.000MB -2.7%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 54.417MB (SLO: <56.000MB -2.8%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: ~same Memory: ✅ 54.365MB (SLO: <56.500MB -3.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: ~same Memory: ✅ 54.337MB (SLO: <60.000MB -9.4%) vs baseline: +4.7%
|
Description
Adds a CI check to verify we do not have any namespace packages in ddtrace/ or tests/.
This also fixes all the current namespace packages that exist in the repo.
Testing
Risks
Additional Notes