-
Notifications
You must be signed in to change notification settings - Fork 468
chore(profiling): remove stack v1 impl #15237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 211 ± 2 ms. The average import time from base is: 217 ± 2 ms. The import time difference between this PR and base is: -5.87 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate prof-12836-v1-removal (a0669b0) with baseline main (3d5a9f3) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.9% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.9% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.0% ✅ add_inplace_noaspectTime: ✅ 0.318µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.6% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.7% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.1% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.6% ✅ bytearray_extend_noaspectTime: ✅ 0.616µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.5% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.4% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 1.279µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -0.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.5% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +3.8% ✅ bytesio_aspectTime: ✅ 1.301µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.4% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +3.8% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.4% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +3.7% ✅ capitalize_noaspectTime: ✅ 0.430µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.7% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.4% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.9% Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +3.6% ✅ decode_aspectTime: ✅ 0.726µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.1% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.9% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.8% ✅ encode_aspectTime: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ encode_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ format_aspectTime: ✅ 3.349µs (SLO: <10.000µs 📉 -66.5%) vs baseline: +0.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 4.007µs (SLO: <10.000µs 📉 -59.9%) vs baseline: 📈 +14.5% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +5.7% ✅ format_map_noaspectTime: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.601µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +1.5% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +4.1% ✅ index_aspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.8% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.5% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +3.9% ✅ join_aspectTime: ✅ 1.394µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.6% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.568µs (SLO: <20.000µs 📉 -87.2%) vs baseline: +2.2% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.9% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.1% ✅ lower_aspectTime: ✅ 2.179µs (SLO: <10.000µs 📉 -78.2%) vs baseline: -1.2% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.8% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +3.9% ✅ lstrip_aspectTime: ✅ 2.212µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -1.4% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.5% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ modulo_aspectTime: ✅ 1.062µs (SLO: <10.000µs 📉 -89.4%) vs baseline: +1.8% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.553µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.6% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.974µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -1.9% Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +5.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.295µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +3.5% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 0.631µs (SLO: <10.000µs 📉 -93.7%) vs baseline: ~same Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +3.6% ✅ replace_aspectTime: ✅ 4.897µs (SLO: <10.000µs 📉 -51.0%) vs baseline: +0.6% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.3% Memory: ✅ 39.597MB (SLO: <41.500MB -4.6%) vs baseline: +4.4% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.6% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 1.865µs (SLO: <20.000µs 📉 -90.7%) vs baseline: -0.9% Memory: ✅ 39.302MB (SLO: <41.500MB -5.3%) vs baseline: +4.4% ✅ rstrip_noaspectTime: ✅ 0.377µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.449µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.6% Memory: ✅ 39.597MB (SLO: <41.500MB -4.6%) vs baseline: +4.1% ✅ stringio_aspectTime: ✅ 1.548µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.9% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.718µs (SLO: <10.000µs 📉 -92.8%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.2% ✅ strip_aspectTime: ✅ 2.222µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.5% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.4% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.2% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.1% ✅ swapcase_aspectTime: ✅ 2.383µs (SLO: <10.000µs 📉 -76.2%) vs baseline: -1.0% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 0.533µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.7% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +3.7% ✅ title_aspectTime: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -1.4% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.4% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.1% ✅ translate_aspectTime: ✅ 3.197µs (SLO: <10.000µs 📉 -68.0%) vs baseline: -1.7% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 1.045µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.7% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.187µs (SLO: <10.000µs 📉 -78.1%) vs baseline: -0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.1% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.1% 🟡 Near SLO Breach (3 suites)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.431ms (SLO: <47.150ms 📉 -18.5%) vs baseline: ~same Memory: ✅ 38.974MB (SLO: <47.000MB 📉 -17.1%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 257.036ms (SLO: <344.800ms 📉 -25.5%) vs baseline: ~same Memory: ✅ 43.332MB (SLO: <47.500MB -8.8%) vs baseline: +5.1% ✅ add-tagsTime: ✅ 316.920ms (SLO: <321.000ms 🟡 -1.3%) vs baseline: +0.4% Memory: ✅ 43.197MB (SLO: <47.500MB -9.1%) vs baseline: +4.6% ✅ get-contextTime: ✅ 78.782ms (SLO: <92.350ms 📉 -14.7%) vs baseline: +0.6% Memory: ✅ 39.287MB (SLO: <46.500MB 📉 -15.5%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 36.167ms (SLO: <44.500ms 📉 -18.7%) vs baseline: -0.3% Memory: ✅ 38.742MB (SLO: <47.500MB 📉 -18.4%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 57.158ms (SLO: <67.650ms 📉 -15.5%) vs baseline: +0.4% Memory: ✅ 39.361MB (SLO: <47.000MB 📉 -16.3%) vs baseline: +4.6% ✅ set-statusTime: ✅ 42.429ms (SLO: <50.400ms 📉 -15.8%) vs baseline: ~same Memory: ✅ 38.778MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +5.0% ✅ startTime: ✅ 35.387ms (SLO: <43.450ms 📉 -18.6%) vs baseline: +0.4% Memory: ✅ 38.737MB (SLO: <47.000MB 📉 -17.6%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.020ms (SLO: <88.000ms -6.8%) vs baseline: +0.4% Memory: ✅ 36.667MB (SLO: <46.500MB 📉 -21.1%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.339ms (SLO: <89.000ms -6.4%) vs baseline: ~same Memory: ✅ 36.549MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +4.7% ✅ update-nameTime: ✅ 36.901ms (SLO: <45.150ms 📉 -18.3%) vs baseline: -0.3% Memory: ✅ 38.860MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +4.5% 🟡 packagespackageforrootmodulemapping - 4/4✅ cache_offTime: ✅ 341.822ms (SLO: <354.300ms -3.5%) vs baseline: -0.3% Memory: ✅ 40.748MB (SLO: <41.500MB 🟡 -1.8%) vs baseline: +5.6% ✅ cache_onTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.2% Memory: ✅ 39.237MB (SLO: <41.000MB -4.3%) vs baseline: +6.2% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.007µs (SLO: <20.000µs 📉 -85.0%) vs baseline: +3.3% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 197.909µs (SLO: <220.000µs 📉 -10.0%) vs baseline: -0.5% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.338µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +1.0% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.293µs (SLO: <220.000µs 🟡 -1.2%) vs baseline: +1.2% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.157µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.7% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.804µs (SLO: <150.000µs -8.8%) vs baseline: -0.3% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.070µs (SLO: <20.000µs 📉 -84.7%) vs baseline: +0.3% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 210.865µs (SLO: <250.000µs 📉 -15.7%) vs baseline: ~same Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.250ms (SLO: <22.000ms -8.0%) vs baseline: +2.0% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.249ms (SLO: <2.300ms -2.2%) vs baseline: -0.9% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.415ms (SLO: <1.550ms -8.7%) vs baseline: +1.2% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.193ms (SLO: <2.550ms 📉 -14.0%) vs baseline: -0.1% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.603µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +0.8% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 174.954µs (SLO: <250.000µs 📉 -30.0%) vs baseline: -0.3% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.112ms (SLO: <2.500ms 📉 -15.5%) vs baseline: -0.5% Memory: ✅ 35.350MB (SLO: <36.500MB -3.2%) vs baseline: +5.2%
|
KowalskiThomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: T. Kowalski <thomas.kowalski@datadoghq.com>
Description
Remove Stack v1 impl,
StackCollector.collect_stack(). There still aretests/profilingandtests/profiling_v2directories, and cleaning up those two will be done in a follow up PR.One notable improvement from this PR is that
StackCollectorno longer inherits fromperiodic.PeriodicCollector, andPeriodicCollectoris also deleted.PeriodicCollectorprovided a mechanism to invoke a Python function periodically using a background native thread. ForStackCollectorit was needed to sample stack.stack_v2creates its own background native thread and handles adaptive sampling its own. So we no longer need to have fields such asinterval,max_time_usage_pctetc inStackCollector.Testing
Risks
Additional Notes
PROF-12836