- 
                Notifications
    You must be signed in to change notification settings 
- Fork 468
fix(llmobs): fix assessment argument description for custom evals #15032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
  | 
| Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 239 ± 4 ms. The average import time from base is: 242 ± 3 ms. The import time difference between this PR and base is: -2.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk: 
             | 
| Performance SLOsComparing candidate yunkim/fix-assessment-description (da16854) with baseline main (429f02c) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.9% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.1% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.499µs (SLO: <10.000µs 📉 -85.0%) vs baseline: 📈 +10.6% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 1.529µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 0.617µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.422µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +9.9% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.360µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.7% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -1.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.374µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.4% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.424µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 0.705µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +1.1% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.416µs (SLO: <10.000µs 📉 -65.8%) vs baseline: +0.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 4.305µs (SLO: <10.000µs 📉 -57.0%) vs baseline: 📈 +17.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 0.779µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.5% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -1.5% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.370µs (SLO: <10.000µs 📉 -86.3%) vs baseline: +0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 2.589µs (SLO: <20.000µs 📉 -87.1%) vs baseline: ~same Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 2.210µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.7% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.0% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.223µs (SLO: <20.000µs 📉 -88.9%) vs baseline: ~same Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 0.996µs (SLO: <10.000µs 📉 -90.0%) vs baseline: -0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.572µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +0.4% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.238µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +1.0% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.623µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -1.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 5.497µs (SLO: <10.000µs 📉 -45.0%) vs baseline: 📈 +10.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -1.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.5% Memory: ✅ 38.162MB (SLO: <39.000MB -2.1%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 1.901µs (SLO: <20.000µs 📉 -90.5%) vs baseline: ~same Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ slice_noaspectTime: ✅ 0.452µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.547µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -1.2% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.227µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.7% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 2.392µs (SLO: <10.000µs 📉 -76.1%) vs baseline: -0.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.2% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.337µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -0.2% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.277µs (SLO: <10.000µs 📉 -67.2%) vs baseline: +1.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.4% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 2.370µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +8.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.597ms (SLO: <22.300ms -7.6%) vs baseline: +0.1% Memory: ✅ 65.273MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.1% Memory: ✅ 64.722MB (SLO: <67.000MB -3.4%) vs baseline: +4.9% ✅ iastTime: ✅ 20.536ms (SLO: <22.250ms -7.7%) vs baseline: ~same Memory: ✅ 65.260MB (SLO: <67.000MB -2.6%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.509ms (SLO: <16.550ms -6.3%) vs baseline: +0.2% Memory: ✅ 54.166MB (SLO: <54.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.592ms (SLO: <21.750ms -5.3%) vs baseline: +0.3% Memory: ✅ 65.292MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.395ms (SLO: <28.200ms -9.9%) vs baseline: -0.2% Memory: ✅ 67.589MB (SLO: <69.500MB -2.7%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.498ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 65.254MB (SLO: <67.000MB -2.6%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 22.712ms (SLO: <23.500ms -3.4%) vs baseline: +0.1% Memory: ✅ 66.780MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.369ms (SLO: <21.500ms -9.9%) vs baseline: +0.4% Memory: ✅ 65.273MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.608ms (SLO: <17.500ms -5.1%) vs baseline: -0.3% Memory: ✅ 65.274MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.473ms (SLO: <21.750ms -5.9%) vs baseline: -0.1% Memory: ✅ 71.467MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +5.1% ✅ tracer-no-cachesTime: ✅ 18.481ms (SLO: <19.650ms -5.9%) vs baseline: +0.2% Memory: ✅ 65.254MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.802ms (SLO: <20.100ms -6.5%) vs baseline: +0.4% Memory: ✅ 65.252MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.168ms (SLO: <21.500ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.273MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.342ms (SLO: <22.000ms -7.5%) vs baseline: ~same Memory: ✅ 65.252MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.104ms (SLO: <19.850ms -8.8%) vs baseline: ~same Memory: ✅ 65.202MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.091ms (SLO: <19.400ms -6.7%) vs baseline: ~same Memory: ✅ 65.236MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 18.090ms (SLO: <19.450ms -7.0%) vs baseline: +0.2% Memory: ✅ 65.160MB (SLO: <66.500MB -2.0%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.071ms (SLO: <2.300ms -9.9%) vs baseline: -0.2% Memory: ✅ 52.140MB (SLO: <53.500MB -2.5%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 2.077ms (SLO: <2.250ms -7.7%) vs baseline: +0.3% Memory: ✅ 52.042MB (SLO: <53.500MB -2.7%) vs baseline: +4.3% ✅ tracer-enabledTime: ✅ 2.073ms (SLO: <2.300ms -9.9%) vs baseline: ~same Memory: ✅ 52.455MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.597ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.618ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: -0.1% Memory: ✅ 61.935MB (SLO: <65.000MB -4.7%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.583ms (SLO: <4.750ms -3.5%) vs baseline: -0.1% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: -0.3% Memory: ✅ 45.436MB (SLO: <47.000MB -3.3%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.4% Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: -0.2% Memory: ✅ 46.635MB (SLO: <47.000MB 🟡 -0.8%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 52.140MB (SLO: <53.500MB -2.5%) vs baseline: +4.5% ✅ tracerTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: -0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: +0.2% Memory: ✅ 58.186MB (SLO: <60.000MB -3.0%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.959ms (SLO: <4.200ms -5.7%) vs baseline: -0.1% Memory: ✅ 62.246MB (SLO: <66.000MB -5.7%) vs baseline: +4.9% ✅ iast-enabledTime: ✅ 2.450ms (SLO: <2.800ms 📉 -12.5%) vs baseline: +1.0% Memory: ✅ 58.904MB (SLO: <60.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.064ms (SLO: <2.250ms -8.3%) vs baseline: ~same Memory: ✅ 52.180MB (SLO: <54.500MB -4.3%) vs baseline: +4.4% 
 | 
…5032) ## Description Corrects the docstring description of the `assessment` argument in `submit_evaluation()`. There is no functional change but the docstring description was incorrect. <!-- Provide an overview of the change and motivation for the change --> ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 314c76e)
…5032) Corrects the docstring description of the `assessment` argument in `submit_evaluation()`. There is no functional change but the docstring description was incorrect. <!-- Provide an overview of the change and motivation for the change --> <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 314c76e)
…ckport 3.17] (#15033) Backport 314c76e from #15032 to 3.17. ## Description Corrects the docstring description of the `assessment` argument in `submit_evaluation()`. There is no functional change but the docstring description was incorrect. <!-- Provide an overview of the change and motivation for the change --> ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Description
Corrects the docstring description of the
assessmentargument insubmit_evaluation(). There is no functional change but the docstring description was incorrect.Testing
Risks
Additional Notes