ci: pin wrapt<2 in typing checker #14971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
added
the
changelog/no-changelog
juanjux
approved these changes
Oct 21, 2025
wantsui
approved these changes
Oct 21, 2025
|
|
emmettbutler
approved these changes
Oct 21, 2025
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 9 ms. The average import time from base is: 246 ± 8 ms. The import time difference between this PR and base is: 0.7 ± 0.4 ms. The difference is not statistically significant (z = 1.96). Import time breakdownThe following import paths have shrunk:
|
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 0b0f0d3)
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 0b0f0d3)
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 0b0f0d3)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 0b0f0d3)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 0b0f0d3)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 0b0f0d3)
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
Backport 0b0f0d3 from #14971 to 3.16. ## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
Backport 0b0f0d3 from #14971 to 3.15. ## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2025
Backport 0b0f0d3 from #14971 to 3.14. ## Description ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2". ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ddapm-test-agent installs vcrpy which installs "wrapt" with no constraints. This meant we were still install wrapt 2.0 in our hatch lint environment causing us to type against wrapt 2 even though we updated pyproject.toml to be "wrapt>=1,<2".
Testing
Risks
Additional Notes