-
Notifications
You must be signed in to change notification settings - Fork 447
chore(ci): riotize pytest_plugin_v2 #14003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 298 ± 6 ms. The average import time from base is: 292 ± 6 ms. The import time difference between this PR and base is: 5.4 ± 0.3 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-07-16 14:01:59 Comparing candidate commit 284dd4f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 548 metrics, 2 unstable metrics. |
…t-v2 # Conflicts: # riotfile.py
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
…g/dd-trace-py into juanjux/riotize-pytest-v2
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
riotfile.py
Outdated
"msgpack": latest, | ||
"requests": latest, | ||
"hypothesis": latest, | ||
"pytest-xdist": latest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think xdist
was not installed in the hatch version, right? It changes things as there is extra logic in place for our pytest
plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, pytest-cov
was installed and it is not here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it was on a separate venv hanging from the root one it failed without it. However now is hanging from the pytest venv and it already have the xdist dep so it should be redundant.
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Checklist
Reviewer Checklist