Skip to content

chore(ci): riotize pytest_plugin_v2 #14003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jul 15, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux self-assigned this Jul 15, 2025
@juanjux juanjux added the CI label Jul 15, 2025
Copy link
Contributor

github-actions bot commented Jul 15, 2025

CODEOWNERS have been resolved as:

.riot/requirements/10fafcd.txt                                          @DataDog/apm-python
.riot/requirements/12cf79a.txt                                          @DataDog/apm-python
.riot/requirements/12d9f7a.txt                                          @DataDog/apm-python
.riot/requirements/157020e.txt                                          @DataDog/apm-python
.riot/requirements/180a759.txt                                          @DataDog/apm-python
.riot/requirements/19de119.txt                                          @DataDog/apm-python
.riot/requirements/3895842.txt                                          @DataDog/apm-python
.riot/requirements/5d311fc.txt                                          @DataDog/apm-python
.riot/requirements/db4e80f.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
lib-injection/sources/requirements.csv                                  @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
tests/ci_visibility/suitespec.yml                                       @DataDog/ci-app-libraries

Copy link
Contributor

github-actions bot commented Jul 15, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 298 ± 6 ms.

The average import time from base is: 292 ± 6 ms.

The import time difference between this PR and base is: 5.4 ± 0.3 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.120 ms (0.04%)
ddtrace.bootstrap.sitecustomize 0.120 ms (0.04%)
ddtrace._trace.trace_handlers 0.090 ms (0.03%)
ddtrace._trace._inferred_proxy 0.090 ms (0.03%)
ddtrace.propagation.http 0.090 ms (0.03%)
ddtrace.bootstrap.preload 0.030 ms (0.01%)
multiprocessing.sharedctypes 0.030 ms (0.01%)

The following import paths have shrunk:

ddtrace.auto 1.203 ms (0.40%)
ddtrace 0.663 ms (0.22%)
ddtrace.bootstrap.sitecustomize 0.540 ms (0.18%)
ddtrace.bootstrap.preload 0.540 ms (0.18%)
ddtrace.internal.remoteconfig.client 0.540 ms (0.18%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 15, 2025

Benchmarks

Benchmark execution time: 2025-07-16 14:01:59

Comparing candidate commit 284dd4f in PR branch juanjux/riotize-pytest-v2 with baseline commit 914ca9c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 548 metrics, 2 unstable metrics.

juanjux added 2 commits July 15, 2025 15:27
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 15, 2025
juanjux added 9 commits July 15, 2025 16:06
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux marked this pull request as ready for review July 16, 2025 09:50
@juanjux juanjux requested review from a team as code owners July 16, 2025 09:50
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
juanjux added 2 commits July 16, 2025 15:03
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux enabled auto-merge (squash) July 16, 2025 13:14
riotfile.py Outdated
"msgpack": latest,
"requests": latest,
"hypothesis": latest,
"pytest-xdist": latest,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think xdist was not installed in the hatch version, right? It changes things as there is extra logic in place for our pytest plugin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, pytest-cov was installed and it is not here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it was on a separate venv hanging from the root one it failed without it. However now is hanging from the pytest venv and it already have the xdist dep so it should be redundant.

juanjux added 2 commits July 16, 2025 16:30
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants