Skip to content

ci: remove 2.21 backport action #13986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jul 14, 2025

This is no longer necessary, we are not trying to force all bug fixes to 2.21 branch

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This is no longer necessary, we are not trying to force all bug fixes to 2.21 branch
@brettlangdon brettlangdon requested a review from erikayasuda July 14, 2025 16:33
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 14, 2025
@brettlangdon brettlangdon requested review from a team as code owners July 14, 2025 16:33
@brettlangdon brettlangdon enabled auto-merge (squash) July 14, 2025 16:33
@erikayasuda
Copy link
Contributor

🎉

Copy link
Contributor

github-actions bot commented Jul 14, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 278 ± 3 ms.

The average import time from base is: 284 ± 7 ms.

The import time difference between this PR and base is: -6.5 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.387 ms (0.86%)
ddtrace.bootstrap.sitecustomize 1.695 ms (0.61%)
ddtrace.bootstrap.preload 1.695 ms (0.61%)
ddtrace.internal.remoteconfig.client 0.752 ms (0.27%)
ddtrace 0.692 ms (0.25%)
ddtrace.internal._unpatched 0.033 ms (0.01%)
json 0.033 ms (0.01%)
json.decoder 0.033 ms (0.01%)
re 0.033 ms (0.01%)
enum 0.033 ms (0.01%)
types 0.033 ms (0.01%)

@erikayasuda
Copy link
Contributor

@brettlangdon The codeowners job keeps failing because it's trying to resolve for way too many files? 🤔

@brettlangdon
Copy link
Member Author

@brettlangdon The codeowners job keeps failing because it's trying to resolve for way too many files? 🤔

yeah, it is weird, it sometimes struggles to find the changed files, so then defaults to all files in the repo

@pr-commenter
Copy link

pr-commenter bot commented Jul 14, 2025

Benchmarks

Benchmark execution time: 2025-07-14 19:34:37

Comparing candidate commit c3e1f59 in PR branch brettlangdon/2.21.backport.action with baseline commit b4bdef9 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 537 metrics, 2 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+457.878ns; +511.964ns] or [+14.085%; +15.748%]

scenario:iastaspectsospath-ospathjoin_aspect

  • 🟥 execution_time [+0.983µs; +1.063µs] or [+15.983%; +17.283%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+370.666ns; +429.718ns] or [+10.593%; +12.281%]

@brettlangdon brettlangdon merged commit d1785de into main Jul 14, 2025
392 of 393 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/2.21.backport.action branch July 14, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants