Skip to content

Consolidate libdatadog symbols in lib_native #13984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

hoolioh
Copy link

@hoolioh hoolioh commented Jul 14, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

hoolioh added 8 commits July 14, 2025 16:55
* Add new cmake file to find libnative components.
* Modify dd_wrapper cmake in order to link against libnative.
* Modify ddup cmake in order to link against libnative.
* Change crashtracker compilation so it links agains libnative. Link to
  python runtime as a workaround to solve secondary dependencies from
  libnative.so (temporary until the crashtracker PyO3 bindings are
  ready).
* Call build_libnative from project's root folder.
* Fix FindLibNative in order not to include libnative whole folder
  structure.
* Workaround test linking.
@hoolioh hoolioh added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 14, 2025
Copy link
Contributor

github-actions bot commented Jul 14, 2025

CODEOWNERS have been resolved as:

build_libnative.py                                                      @DataDog/apm-core-python
ddtrace/internal/datadog/profiling/cmake/FindLibNative.cmake            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/crashtracker/python_runtime_stub.c   @DataDog/profiling-python
src/native/.cargo/config.toml                                           @DataDog/apm-core-python
.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_iast/_taint_tracking/CMakeLists.txt                     @DataDog/asm-python
ddtrace/internal/datadog/profiling/build_standalone.sh                  @DataDog/profiling-python
ddtrace/internal/datadog/profiling/crashtracker/CMakeLists.txt          @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/CMakeLists.txt            @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/test/CMakeLists.txt       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/ddup/CMakeLists.txt                  @DataDog/profiling-python
setup.py                                                                @DataDog/python-guild
src/native/Cargo.lock                                                   @DataDog/apm-core-python
src/native/Cargo.toml                                                   @DataDog/apm-core-python
src/native/lib.rs                                                       @DataDog/apm-core-python

@hoolioh hoolioh changed the title Julio/merge libraries new branch Consolidate libdatadog symbols in lib_native Jul 14, 2025
Copy link
Contributor

No description provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant