-
Notifications
You must be signed in to change notification settings - Fork 447
chore(llmobs): support running experiment tasks #13970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 280 ± 4 ms. The average import time from base is: 282 ± 4 ms. The import time difference between this PR and base is: -2.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-15 01:44:55 Comparing candidate commit c70bb0d in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 546 metrics, 2 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspectsospath-ospathjoin_aspect
|
cdfb6fa
to
9ef1d9e
Compare
9ef1d9e
to
50f602e
Compare
50f602e
to
6937e9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some thoughts, i think i'd change the log/raise condition check for sure but trust you to address what you feel is necessary
MLOB-3272
Adds support for running experiment task functions concurrently, and tracing said experiment tasks.
Also does the following:
DatasetRecord.input_data
a more strictDict[str, NonNoneJSONType]
. There was a discrepancy between previous iterations of input_data from the DatasetRecord class and the required signature fortask
functions.config
a required input param (can be optional though) for task functions. Making it possibly optional is too clunky of an experience and users should be required to set itChecklist
Reviewer Checklist