Skip to content

ci(testrunner): add dd-octo-sts and gh cli tools to testrunner image #13965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

brettlangdon
Copy link
Member

Needed for #13948 so we can migrate test-gen job to dd-octo-sts.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon requested a review from a team as a code owner July 11, 2025 18:02
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 11, 2025
@brettlangdon brettlangdon enabled auto-merge (squash) July 11, 2025 18:02
Copy link
Contributor

CODEOWNERS have been resolved as:

docker/Dockerfile                                                       @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 3 ms.

The average import time from base is: 280 ± 2 ms.

The import time difference between this PR and base is: -1.6 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.923 ms (0.69%)
ddtrace.bootstrap.sitecustomize 1.250 ms (0.45%)
ddtrace.bootstrap.preload 1.250 ms (0.45%)
ddtrace.internal.remoteconfig.client 0.633 ms (0.23%)
ddtrace 0.673 ms (0.24%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2025

Benchmarks

Benchmark execution time: 2025-07-11 18:49:17

Comparing candidate commit 3afec28 in PR branch LANGPLAT-661/update.dockerfile with baseline commit c7c99b3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 460 metrics, 2 unstable metrics.

@brettlangdon brettlangdon disabled auto-merge July 14, 2025 13:25
@brettlangdon
Copy link
Member Author

I am not sure this is going to work, since it requires grabbing an artifact from an internal repo... and we build this image in GitHub Actions 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants