Skip to content

ci: fix chainguard claim pattern #13962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jul 11, 2025

Following the pattern from vaccine, we don't need the claim_pattern at all

https://github.com/DataDog/vaccine/blob/master/.github/chainguard/dd-trace-rb.dispatch.sts.yaml

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon requested review from a team as code owners July 11, 2025 13:36
@brettlangdon brettlangdon requested a review from avara1986 July 11, 2025 13:36
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 11, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/chainguard/gitlab.github-access.read.sts.yaml                   @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon enabled auto-merge (squash) July 11, 2025 13:43
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 286 ± 5 ms.

The average import time from base is: 287 ± 6 ms.

The import time difference between this PR and base is: -1.5 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.973 ms (0.69%)
ddtrace.bootstrap.sitecustomize 1.292 ms (0.45%)
ddtrace.bootstrap.preload 1.292 ms (0.45%)
ddtrace.internal.remoteconfig.client 0.647 ms (0.23%)
ddtrace 0.680 ms (0.24%)
ddtrace.internal._unpatched 0.034 ms (0.01%)
json 0.034 ms (0.01%)
json.decoder 0.034 ms (0.01%)
re 0.034 ms (0.01%)
enum 0.034 ms (0.01%)
types 0.034 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2025

Benchmarks

Benchmark execution time: 2025-07-11 14:22:55

Comparing candidate commit d614e55 in PR branch LANGPLAT-661/fix.chainguard with baseline commit 3a8fd53 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 436 metrics, 2 unstable metrics.

@brettlangdon brettlangdon merged commit 0bdc1e4 into main Jul 11, 2025
394 checks passed
@brettlangdon brettlangdon deleted the LANGPLAT-661/fix.chainguard branch July 11, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants