Skip to content

chore(ci): riotize-threats-fastapi #13939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 11, 2025
Merged

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jul 10, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux self-assigned this Jul 10, 2025
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring CI labels Jul 10, 2025
Copy link
Contributor

github-actions bot commented Jul 10, 2025

CODEOWNERS have been resolved as:

.riot/requirements/13b7789.txt                                          @DataDog/apm-python
.riot/requirements/184912e.txt                                          @DataDog/apm-python
.riot/requirements/19024d0.txt                                          @DataDog/apm-python
.riot/requirements/1b02ea2.txt                                          @DataDog/apm-python
.riot/requirements/206be6b.txt                                          @DataDog/apm-python
.riot/requirements/40adc31.txt                                          @DataDog/apm-python
.riot/requirements/410afd4.txt                                          @DataDog/apm-python
.riot/requirements/820f02e.txt                                          @DataDog/apm-python
.riot/requirements/bf3c54f.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Jul 10, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 277 ± 2 ms.

The average import time from base is: 279 ± 2 ms.

The import time difference between this PR and base is: -1.89 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.984 ms (0.72%)
ddtrace.bootstrap.sitecustomize 1.309 ms (0.47%)
ddtrace.bootstrap.preload 1.309 ms (0.47%)
ddtrace.internal.remoteconfig.client 0.647 ms (0.23%)
ddtrace 0.676 ms (0.24%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2025

Benchmarks

Benchmark execution time: 2025-07-11 14:45:42

Comparing candidate commit 34c92d8 in PR branch juanjux/riotize-threats-fastapi with baseline commit 07d0791 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+368.447ns; +465.021ns] or [+11.387%; +14.372%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+274.447ns; +338.050ns] or [+9.467%; +11.661%]

…ts-fastapi

# Conflicts:
#	hatch.toml
#	riotfile.py
@juanjux juanjux marked this pull request as ready for review July 10, 2025 15:53
@juanjux juanjux requested review from a team as code owners July 10, 2025 15:53
@juanjux juanjux requested review from gnufede and tabgok July 10, 2025 15:53
juanjux added 6 commits July 10, 2025 18:15
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
juanjux added 3 commits July 11, 2025 10:37
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux enabled auto-merge (squash) July 11, 2025 10:18
@juanjux juanjux disabled auto-merge July 11, 2025 10:30
juanjux added 2 commits July 11, 2025 12:40
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux enabled auto-merge (squash) July 11, 2025 10:43
@juanjux juanjux merged commit 3626887 into main Jul 11, 2025
876 checks passed
@juanjux juanjux deleted the juanjux/riotize-threats-fastapi branch July 11, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants