Skip to content

chore(llmobs): flaky crew ai test #13913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged

chore(llmobs): flaky crew ai test #13913

merged 4 commits into from
Jul 9, 2025

Conversation

lievan
Copy link
Contributor

@lievan lievan commented Jul 8, 2025

From this ci failure, i see some unmatched requests during cassette tests for crew ai
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1018541008

The requests are to testagent and telemetry.crewai.com

this PR tries to fix it by adding those hosts to ignore_hosts

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@lievan lievan requested a review from a team as a code owner July 8, 2025 15:24
@lievan lievan added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

CODEOWNERS have been resolved as:

tests/contrib/crewai/conftest.py                                        @DataDog/ml-observability

Copy link
Contributor

github-actions bot commented Jul 8, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 280 ± 3 ms.

The average import time from base is: 284 ± 3 ms.

The import time difference between this PR and base is: -3.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.072 ms (0.74%)
ddtrace.bootstrap.sitecustomize 1.394 ms (0.50%)
ddtrace.bootstrap.preload 1.394 ms (0.50%)
ddtrace.internal.remoteconfig.client 0.687 ms (0.24%)
ddtrace 0.678 ms (0.24%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@lievan lievan enabled auto-merge (squash) July 8, 2025 16:29
@pr-commenter
Copy link

pr-commenter bot commented Jul 8, 2025

Benchmarks

Benchmark execution time: 2025-07-09 15:29:52

Comparing candidate commit 42b4ac8 in PR branch evan.li/fix-crew-flake with baseline commit 573a530 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 515 metrics, 2 unstable metrics.

scenario:iastaspects-replace_aspect

  • 🟥 execution_time [+694.474ns; +768.046ns] or [+14.642%; +16.193%]

@lievan lievan merged commit ff294ae into main Jul 9, 2025
398 checks passed
@lievan lievan deleted the evan.li/fix-crew-flake branch July 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants