-
Notifications
You must be signed in to change notification settings - Fork 447
chore(tracer): adding additional validation for jsonpath syntax for aws payload tagging #13896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 297 ± 7 ms. The average import time from base is: 298 ± 8 ms. The import time difference between this PR and base is: -1.7 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
17946d2
to
26940a2
Compare
BenchmarksBenchmark execution time: 2025-07-07 17:49:21 Comparing candidate commit fc08988 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 546 metrics, 3 unstable metrics. scenario:iastaspectsospath-ospathjoin_aspect
|
Add a check for leading "$" in AWS Payload tagging JSONPath parser
Why do we need this check?
parse()
injsonpath_ng
technically doesn’t require a leading $ for valid JSONPath expressions to allow more flexibility in syntax styling. So any string, such as “false”, “none”, were considered valid JSONPaths for this function and thus turned on the feature with no redaction rules applied.We’re requiring the leading “$” to match the JSONpath validator linked in our docs and the JSONPath RFC and also so that we won’t turn on this payload tagging feature if user specifies something that suggests they want it turned off, such as “false”, in the environment variables
https://datadoghq.atlassian.net/browse/APMSVLS-51
Checklist
Reviewer Checklist