-
Notifications
You must be signed in to change notification settings - Fork 457
chore(tracer): add abstract base class for AgentWriterInterface #13876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preparing the code for a future where we have multiple implementations of the AgentWriter
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 284 ± 4 ms. The average import time from base is: 288 ± 5 ms. The import time difference between this PR and base is: -3.6 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-07-10 13:07:26 Comparing candidate commit a328c9b in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 547 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathjoin_aspect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Co-authored-by: Vítor De Araújo <vitor.dearaujo@datadoghq.com>
Preparing the code for a future where we have multiple implementations of the AgentWriter. I grabbed some minor adjacent type hinting stuff as well. Split from #13071 We expect no major changes from this change. The only interesting change is the `agent_url` -> `intake_url` change which this is an internal/private class. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Preparing the code for a future where we have multiple implementations of the AgentWriter.
I grabbed some minor adjacent type hinting stuff as well.
Split from #13071
We expect no major changes from this change. The only interesting change is the
agent_url
->intake_url
change which this is an internal/private class.Checklist
Reviewer Checklist