Skip to content

fix(ci_visibility): split payload in chunks if needed #13825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jun 30, 2025

CI Visibility: Split payloads to the intake if they are bigger than 5MB in size

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jun 30, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/fix-ci-visibility-payload-splitting-11d5f9d69ad25a15.yaml  @DataDog/apm-python
ddtrace/internal/ci_visibility/encoder.py                               @DataDog/ci-app-libraries
ddtrace/internal/writer/writer.py                                       @DataDog/apm-core-python
tests/ci_visibility/test_ci_visibility.py                               @DataDog/ci-app-libraries
tests/ci_visibility/test_encoder.py                                     @DataDog/ci-app-libraries
tests/ci_visibility/test_is_user_provided_service.py                    @DataDog/ci-app-libraries
tests/utils.py                                                          @DataDog/python-guild

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 278 ± 3 ms.

The average import time from base is: 282 ± 4 ms.

The import time difference between this PR and base is: -4.1 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.173 ms (0.78%)
ddtrace.bootstrap.sitecustomize 1.442 ms (0.52%)
ddtrace.bootstrap.preload 1.442 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.683 ms (0.25%)
ddtrace 0.731 ms (0.26%)
ddtrace.internal._unpatched 0.082 ms (0.03%)
subprocess 0.051 ms (0.02%)
contextlib 0.051 ms (0.02%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 30, 2025

Benchmarks

Benchmark execution time: 2025-07-15 08:28:49

Comparing candidate commit 980ab29 in PR branch gnufede/payload-split with baseline commit a89ac3c in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 546 metrics, 2 unstable metrics.

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+386.615ns; +510.067ns] or [+10.528%; +13.890%]

scenario:iastaspectsospath-ospathsplitext_aspect

  • 🟥 execution_time [+701.313ns; +810.666ns] or [+15.368%; +17.765%]

@gnufede gnufede marked this pull request as ready for review July 3, 2025 15:52
@gnufede gnufede requested review from a team as code owners July 3, 2025 15:52
@gnufede gnufede requested a review from vitor-de-araujo July 3, 2025 15:52
@gnufede gnufede requested a review from a team as a code owner July 4, 2025 14:08
@gnufede gnufede requested a review from sabrenner July 4, 2025 14:08
@gnufede gnufede changed the title chore(ci_visibility): split payload in chunks if needed fix(ci_visibility): split payload in chunks if needed Jul 4, 2025
@gnufede gnufede added backport 3.10 and removed changelog/no-changelog A changelog entry is not required for this PR. labels Jul 4, 2025
@gnufede gnufede requested a review from a team as a code owner July 4, 2025 15:33
@gnufede gnufede requested a review from brettlangdon July 4, 2025 15:33
@gnufede gnufede marked this pull request as draft July 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant