Skip to content

chore(asm): keep trace without events if waf decides #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jun 16, 2025

The new version of libddwaf can decide to keep a trace even without security events.
This PR allows to do so.

Also: update system tests version with last commit and remove the agent build step that is now deprecated.

This new internal feature is already checked by new system tests.

APPSEC-58012

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jun 16, 2025
Copy link
Contributor

github-actions bot commented Jun 16, 2025

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Jun 16, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 273 ± 2 ms.

The average import time from base is: 275 ± 2 ms.

The import time difference between this PR and base is: -1.99 ± 0.08 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.983 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.310 ms (0.48%)
ddtrace.bootstrap.preload 1.310 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.632 ms (0.23%)
ddtrace 0.673 ms (0.25%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 16, 2025

Benchmarks

Benchmark execution time: 2025-06-17 09:05:29

Comparing candidate commit 2e1b555 in PR branch christophe-papazian/keep_trace_without_security_events with baseline commit d30bcd7 in branch main.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 555 metrics, 3 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+452.736ns; +528.810ns] or [+14.128%; +16.502%]

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+165.556ns; +205.703ns] or [+7.324%; +9.100%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+803.114ns; +907.737ns] or [+19.154%; +21.649%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+352.988ns; +430.819ns] or [+10.175%; +12.419%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+323.466ns; +388.347ns] or [+8.909%; +10.696%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+359.825ns; +394.045ns] or [+12.427%; +13.609%]

@christophe-papazian christophe-papazian marked this pull request as ready for review June 16, 2025 16:55
@christophe-papazian christophe-papazian requested review from a team as code owners June 16, 2025 16:55
@christophe-papazian christophe-papazian enabled auto-merge (squash) June 16, 2025 16:57
@christophe-papazian christophe-papazian enabled auto-merge (squash) June 17, 2025 09:07
@christophe-papazian christophe-papazian merged commit c6202a9 into main Jun 17, 2025
452 of 453 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/keep_trace_without_security_events branch June 17, 2025 09:10
happynancee pushed a commit that referenced this pull request Jul 7, 2025
The new version of libddwaf can decide to keep a trace even without
security events.
This PR allows to do so.

Also: update system tests version with last commit and remove the agent
build step that is now deprecated.

This new internal feature is already checked by new system tests.

APPSEC-58012

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
alyshawang pushed a commit that referenced this pull request Jul 25, 2025
The new version of libddwaf can decide to keep a trace even without
security events.
This PR allows to do so.

Also: update system tests version with last commit and remove the agent
build step that is now deprecated.

This new internal feature is already checked by new system tests.

APPSEC-58012

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants