-
Notifications
You must be signed in to change notification settings - Fork 450
chore(asm): keep trace without events if waf decides #13677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(asm): keep trace without events if waf decides #13677
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 2 ms. The average import time from base is: 275 ± 2 ms. The import time difference between this PR and base is: -1.99 ± 0.08 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-17 09:05:29 Comparing candidate commit 2e1b555 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 555 metrics, 3 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspects-lower_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
The new version of libddwaf can decide to keep a trace even without security events. This PR allows to do so. Also: update system tests version with last commit and remove the agent build step that is now deprecated. This new internal feature is already checked by new system tests. APPSEC-58012 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
The new version of libddwaf can decide to keep a trace even without security events. This PR allows to do so. Also: update system tests version with last commit and remove the agent build step that is now deprecated. This new internal feature is already checked by new system tests. APPSEC-58012 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
The new version of libddwaf can decide to keep a trace even without security events.
This PR allows to do so.
Also: update system tests version with last commit and remove the agent build step that is now deprecated.
This new internal feature is already checked by new system tests.
APPSEC-58012
Checklist
Reviewer Checklist