Skip to content

chore: make cythonize incremental by default #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jun 16, 2025

We make the cythonisation of pyx sources incremental by default. The old behaviour whereby all Cython sources are forcibly re-transpiled can be recovered by setting DD_SETUP_FORCE_CYTHONIZE=1.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We make the cythonisation of pyx sources incremental by default. The old
behaviour whereby all Cython sources are forcibly re-transpiled can be
recovered by setting `DD_SETUP_FORCE_CYTHONIZE=1`.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 16, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

setup.py                                                                @DataDog/python-guild

@P403n1x87 P403n1x87 marked this pull request as ready for review June 16, 2025 14:50
@P403n1x87 P403n1x87 requested a review from a team as a code owner June 16, 2025 14:50
@P403n1x87 P403n1x87 requested a review from taegyunkim June 16, 2025 14:50
@P403n1x87 P403n1x87 enabled auto-merge (squash) June 16, 2025 14:50
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 274 ± 2 ms.

The average import time from base is: 278 ± 3 ms.

The import time difference between this PR and base is: -4.3 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.178 ms (0.79%)
ddtrace.bootstrap.sitecustomize 1.503 ms (0.55%)
ddtrace.bootstrap.preload 1.503 ms (0.55%)
ddtrace.internal.remoteconfig.client 0.671 ms (0.24%)
ddtrace 0.675 ms (0.25%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 16, 2025

Benchmarks

Benchmark execution time: 2025-06-16 15:02:15

Comparing candidate commit a1ad396 in PR branch chore/incremental-cythonize with baseline commit 5692392 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 412 metrics, 3 unstable metrics.

scenario:iastaspectssplit-splitlines_aspect

  • 🟥 execution_time [+104.001ns; +133.565ns] or [+7.023%; +9.019%]

@P403n1x87 P403n1x87 merged commit d30bcd7 into main Jun 16, 2025
824 of 826 checks passed
@P403n1x87 P403n1x87 deleted the chore/incremental-cythonize branch June 16, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants