Skip to content

ci: skip windows 3.13 multiple os unit tests #13666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jun 13, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon requested review from a team as code owners June 13, 2025 13:31
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 13, 2025
@brettlangdon brettlangdon enabled auto-merge (squash) June 13, 2025 13:32
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/unit_tests.yml                                        @DataDog/python-guild @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 4 ms.

The average import time from base is: 279 ± 3 ms.

The import time difference between this PR and base is: -3.3 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.123 ms (0.77%)
ddtrace.bootstrap.sitecustomize 1.444 ms (0.52%)
ddtrace.bootstrap.preload 1.444 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.676 ms (0.25%)
ddtrace 0.679 ms (0.25%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2025

Benchmarks

Benchmark execution time: 2025-06-13 14:23:01

Comparing candidate commit 23532f0 in PR branch brettlangdon/skip.windows.313.tests with baseline commit 554be85 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 561 metrics, 3 unstable metrics.

@brettlangdon brettlangdon merged commit 8594048 into main Jun 13, 2025
363 of 364 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/skip.windows.313.tests branch June 13, 2025 14:24
Copy link
Contributor

The backport to 2.21 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13666-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 85940480ad9ae0164655689cc0ef41685c933364
# Push it to GitHub
git push --set-upstream origin backport-13666-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21

Then, create a pull request where the base branch is 2.21 and the compare/head branch is backport-13666-to-2.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.21 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants