Skip to content

ci(tracer): fix precommit hook for ruff #13664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025
Merged

Conversation

avara1986
Copy link
Member

Ruff was updated, and the command ruff . is now deprecated, it's been replaced by ruff check ., but it wasn’t properly updated in the pre-commit hooks.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jun 13, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

hooks/scripts/run-ruff.sh                                               @DataDog/apm-core-python

@avara1986 avara1986 marked this pull request as ready for review June 13, 2025 10:04
@avara1986 avara1986 requested a review from a team as a code owner June 13, 2025 10:04
@avara1986 avara1986 requested a review from brettlangdon June 13, 2025 10:04
Copy link
Contributor

github-actions bot commented Jun 13, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 271 ± 3 ms.

The average import time from base is: 273 ± 3 ms.

The import time difference between this PR and base is: -1.9 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.014 ms (0.74%)
ddtrace.bootstrap.sitecustomize 1.335 ms (0.49%)
ddtrace.bootstrap.preload 1.335 ms (0.49%)
ddtrace.internal.remoteconfig.client 0.638 ms (0.24%)
ddtrace 0.679 ms (0.25%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@P403n1x87 P403n1x87 enabled auto-merge (squash) June 13, 2025 10:31
@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2025

Benchmarks

Benchmark execution time: 2025-06-14 14:47:29

Comparing candidate commit b03e592 in PR branch avara1986/ci_fix_precommits with baseline commit 990b1bf in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 559 metrics, 3 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+273.863ns; +403.458ns] or [+8.536%; +12.575%]

scenario:telemetryaddmetric-1-gauge-metric-1-times

  • 🟥 execution_time [+279.255ns; +320.098ns] or [+13.026%; +14.931%]

@P403n1x87 P403n1x87 merged commit 98e661a into main Jun 14, 2025
359 checks passed
@P403n1x87 P403n1x87 deleted the avara1986/ci_fix_precommits branch June 14, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants