Skip to content

chore(config): use DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED instead of DD_TRACE_RUNTIME_ID_ENABLED #13644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Jun 11, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@ZStriker19 ZStriker19 requested review from a team as code owners June 11, 2025 15:19
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/add_DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED-8e9d518dfd0028f2.yaml  @DataDog/apm-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
docs/configuration.rst                                                  @DataDog/python-guild
tests/runtime/test_runtime_metrics_api.py                               @DataDog/apm-sdk-api-python

@brettlangdon brettlangdon changed the title feat: switch config to DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED chore(config): use DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED instead of DD_TRACE_RUNTIME_ID_ENABLED Jun 11, 2025
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 11, 2025
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 276 ± 4 ms.

The average import time from base is: 284 ± 5 ms.

The import time difference between this PR and base is: -8.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 3.057 ms (1.11%)
ddtrace.bootstrap.sitecustomize 1.986 ms (0.72%)
ddtrace.bootstrap.preload 1.986 ms (0.72%)
ddtrace.internal.remoteconfig.client 0.774 ms (0.28%)
ddtrace.debugging._import 0.019 ms (0.01%)
ddtrace 1.072 ms (0.39%)
ddtrace.internal._unpatched 0.154 ms (0.06%)
subprocess 0.125 ms (0.05%)
selectors 0.125 ms (0.05%)
ddtrace.settings._config 0.153 ms (0.06%)
ddtrace.internal._file_queue 0.153 ms (0.06%)
secrets 0.153 ms (0.06%)
hmac 0.153 ms (0.06%)
_hashlib 0.153 ms (0.06%)
ddtrace.trace 0.057 ms (0.02%)
ddtrace._logger 0.043 ms (0.02%)
ddtrace.internal.telemetry 0.043 ms (0.02%)
ddtrace.settings._agent 0.043 ms (0.02%)
socket 0.043 ms (0.02%)
_socket 0.043 ms (0.02%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2025

Benchmarks

Benchmark execution time: 2025-06-11 16:11:07

Comparing candidate commit 4d9cba6 in PR branch zachg/add_DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED with baseline commit 1b249e1 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 560 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+364.507ns; +420.660ns] or [+9.937%; +11.468%]

@ZStriker19 ZStriker19 merged commit fae0efb into main Jun 11, 2025
826 of 829 checks passed
@ZStriker19 ZStriker19 deleted the zachg/add_DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED branch June 11, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants