-
Notifications
You must be signed in to change notification settings - Fork 440
chore: fix ER single snapshot capture #13642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We fix the logic that ensures that we have at least one ER capture when the traceback comprises only third-party frames.
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 282 ± 7 ms. The average import time from base is: 283 ± 7 ms. The import time difference between this PR and base is: -0.5 ± 0.3 ms. The difference is not statistically significant (z = -1.47). Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-13 21:09:38 Comparing candidate commit f652471 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 563 metrics, 7 unstable metrics. scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplit_aspect
|
@P403n1x87 Does code origins also need this same change? I noticed a span with |
Ah interesting. If there is no code origin information it means that the full stack does not have any user frames 🤔 I think it would be hard to choose which frames to capture in this case |
We fix the logic that ensures that we have at least one ER capture when the traceback comprises only third-party frames.
Checklist
Reviewer Checklist