Skip to content

chore(ci_visibility): aggregate ITR skips in xdist main process #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jun 10, 2025

CI Visibility: When the plugin is used with xdist, and ITR feature is enabled, the number of skipped tests should be aggregated in the main session.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jun 10, 2025

CODEOWNERS have been resolved as:

tests/contrib/pytest/test_pytest_xdist_itr.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/ext/test_visibility/api.py                                      @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/api/_base.py                             @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/api/_session.py                          @DataDog/ci-app-libraries
ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries
ddtrace/internal/test_visibility/api.py                                 @DataDog/ci-app-libraries
tests/contrib/pytest/test_xdist_context_propagation.py                  @DataDog/ci-app-libraries

Copy link
Contributor

github-actions bot commented Jun 10, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 274 ± 3 ms.

The average import time from base is: 275 ± 2 ms.

The import time difference between this PR and base is: -0.7 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.875 ms (0.68%)
ddtrace.bootstrap.sitecustomize 1.200 ms (0.44%)
ddtrace.bootstrap.preload 1.200 ms (0.44%)
ddtrace.internal.remoteconfig.client 0.595 ms (0.22%)
ddtrace 0.675 ms (0.25%)
ddtrace.internal._unpatched 0.031 ms (0.01%)
json 0.031 ms (0.01%)
json.decoder 0.031 ms (0.01%)
re 0.031 ms (0.01%)
enum 0.031 ms (0.01%)
types 0.031 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2025

Benchmarks

Benchmark execution time: 2025-06-14 09:56:48

Comparing candidate commit d021aac in PR branch gnufede/SDTEST-2150-pytest-xdist-itr-skipped-tests-for-nodes-are-aggregated-in-main-process with baseline commit 7709199 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 562 metrics, 7 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+178.622ns; +229.378ns] or [+7.860%; +10.094%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+320.500ns; +360.677ns] or [+10.891%; +12.257%]

scenario:telemetryaddmetric-flush-1-metric

  • 🟥 execution_time [+438.563ns; +587.523ns] or [+10.704%; +14.339%]

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Jun 11, 2025
@gnufede gnufede marked this pull request as ready for review June 12, 2025 09:56
@gnufede gnufede requested a review from a team as a code owner June 12, 2025 09:56
@gnufede gnufede requested a review from Mariovido June 12, 2025 09:56
…-tests-for-nodes-are-aggregated-in-main-process
@gnufede gnufede requested a review from vitor-de-araujo June 12, 2025 09:56
@gnufede gnufede changed the title chore(ci_visibility): xdist main node to aggregate ITR skips chore(ci_visibility): aggregate ITR skips in xdist main process Jun 12, 2025
…-tests-for-nodes-are-aggregated-in-main-process
@gnufede gnufede enabled auto-merge (squash) June 12, 2025 17:31
gnufede added 3 commits June 13, 2025 14:56
…-tests-for-nodes-are-aggregated-in-main-process
…-tests-for-nodes-are-aggregated-in-main-process
…-tests-for-nodes-are-aggregated-in-main-process
@gnufede
Copy link
Member Author

gnufede commented Jun 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 16:45:37 UTC ℹ️ Start processing command /merge


2025-06-13 16:45:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-06-13 16:46:09 UTC ⚠️ MergeQueue: This merge request was unqueued

federico.mon@datadoghq.com unqueued this merge request

@gnufede
Copy link
Member Author

gnufede commented Jun 13, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 16:46:00 UTC ℹ️ Start processing command /remove


2025-06-13 16:46:05 UTC ℹ️ Devflow: /remove

@gnufede
Copy link
Member Author

gnufede commented Jun 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 16:46:28 UTC ℹ️ Start processing command /merge


2025-06-13 16:46:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-06-13 20:47:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

…-tests-for-nodes-are-aggregated-in-main-process
@gnufede gnufede merged commit d7cf750 into main Jun 14, 2025
404 checks passed
@gnufede gnufede deleted the gnufede/SDTEST-2150-pytest-xdist-itr-skipped-tests-for-nodes-are-aggregated-in-main-process branch June 14, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI App mergequeue-status: removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants