Skip to content

feat: add config DD_TRACE_RUNTIME_ID_ENABLED #13618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025

Conversation

ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Jun 6, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jun 6, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/add_DD_TRACE_RUNTIME_ID_ENABLED-8e9d518dfd0028f2.yaml  @DataDog/apm-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
docs/configuration.rst                                                  @DataDog/python-guild
tests/runtime/test_runtime_metrics_api.py                               @DataDog/apm-sdk-api-python

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 276 ± 3 ms.

The average import time from base is: 278 ± 4 ms.

The import time difference between this PR and base is: -2.0 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.012 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.334 ms (0.48%)
ddtrace.bootstrap.preload 1.334 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.637 ms (0.23%)
ddtrace 0.678 ms (0.25%)
ddtrace.internal._unpatched 0.024 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2025

Benchmarks

Benchmark execution time: 2025-06-10 17:14:23

Comparing candidate commit 2fd5a49 in PR branch zachg/add_DD_TRACE_RUNTIME_ID_ENABLED with baseline commit e7c0d74 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 554 metrics, 6 unstable metrics.

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+355.189ns; +403.710ns] or [+9.724%; +11.053%]

scenario:telemetryaddmetric-1-gauge-metric-1-times

  • 🟥 execution_time [+206.603ns; +258.247ns] or [+9.477%; +11.846%]

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one testing thought, otherwise lgtm

@ZStriker19 ZStriker19 enabled auto-merge (squash) June 10, 2025 18:59
@ZStriker19 ZStriker19 disabled auto-merge June 10, 2025 18:59
@ZStriker19 ZStriker19 merged commit 0e795ab into main Jun 10, 2025
808 of 809 checks passed
@ZStriker19 ZStriker19 deleted the zachg/add_DD_TRACE_RUNTIME_ID_ENABLED branch June 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants