Skip to content

feat(er): add in-product enablement support #13610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jun 6, 2025

We add in-product enablement support for Exception Replay.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the Dynamic Instrumentation Dynamic Instrumentation/Live Debugger label Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 6, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/feat-er-in-product-enablement-253418007f82a19b.yaml  @DataDog/apm-python
ddtrace/debugging/_products/exception_replay.py                         @DataDog/debugger-python

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 280 ± 4 ms.

The average import time from base is: 280 ± 3 ms.

The import time difference between this PR and base is: -0.3 ± 0.2 ms.

The difference is not statistically significant (z = -1.67).

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.399 ms (0.14%)
ddtrace.bootstrap.sitecustomize 0.399 ms (0.14%)
ddtrace._trace.trace_handlers 0.158 ms (0.06%)
ddtrace.contrib.trace_utils 0.080 ms (0.03%)
ddtrace.contrib.internal.trace_utils 0.080 ms (0.03%)
ddtrace.contrib.internal.trace_utils_base 0.080 ms (0.03%)
ddtrace.ext.user 0.080 ms (0.03%)
ddtrace._trace._inferred_proxy 0.078 ms (0.03%)
ddtrace.propagation.http 0.078 ms (0.03%)
ddtrace.propagation._utils 0.078 ms (0.03%)
ddtrace.contrib.internal.subprocess.constants 0.086 ms (0.03%)
ddtrace.bootstrap.preload 0.082 ms (0.03%)
ddtrace.appsec._remoteconfiguration 0.082 ms (0.03%)
ddtrace.appsec._common_module_patches 0.073 ms (0.03%)
ddtrace.appsec._asm_request_context 0.073 ms (0.03%)
ddtrace.appsec._utils 0.073 ms (0.03%)

The following import paths have shrunk:

ddtrace.auto 1.672 ms (0.60%)
ddtrace.bootstrap.sitecustomize 1.002 ms (0.36%)
ddtrace.bootstrap.preload 0.704 ms (0.25%)
ddtrace.internal.remoteconfig.client 0.549 ms (0.20%)
ddtrace.internal.remoteconfig.worker 0.079 ms (0.03%)
ddtrace.debugging._import 0.076 ms (0.03%)
ddtrace.debugging._function.discovery 0.076 ms (0.03%)
ddtrace.appsec._common_module_patches 0.167 ms (0.06%)
ddtrace.appsec._asm_request_context 0.084 ms (0.03%)
ddtrace.appsec._metrics 0.083 ms (0.03%)
ddtrace._trace.trace_handlers 0.131 ms (0.05%)
ddtrace 0.670 ms (0.24%)
ddtrace.internal._unpatched 0.021 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2025

Benchmarks

Benchmark execution time: 2025-06-10 11:12:30

Comparing candidate commit 7b78a2a in PR branch feat/er-in-product-enablement with baseline commit 4371460 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 551 metrics, 3 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+214.535ns; +258.757ns] or [+9.448%; +11.396%]

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+635.544ns; +809.907ns] or [+13.131%; +16.734%]

@P403n1x87 P403n1x87 marked this pull request as ready for review June 6, 2025 11:29
@P403n1x87 P403n1x87 requested review from a team as code owners June 6, 2025 11:29
@P403n1x87 P403n1x87 enabled auto-merge (squash) June 6, 2025 11:30
We add in-product enablement support for Exception Replay.
@P403n1x87 P403n1x87 force-pushed the feat/er-in-product-enablement branch from 4188537 to 7b78a2a Compare June 10, 2025 10:19
@P403n1x87 P403n1x87 merged commit 636ffa1 into main Jun 10, 2025
366 of 367 checks passed
@P403n1x87 P403n1x87 deleted the feat/er-in-product-enablement branch June 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants