-
Notifications
You must be signed in to change notification settings - Fork 440
feat(logging): auto enable log injection for structured loggers #13570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BenchmarksBenchmark execution time: 2025-06-15 04:09:32 Comparing candidate commit 15b3ffb in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 560 metrics, 3 unstable metrics. scenario:iastaspectsospath-ospathsplit_aspect
|
8fd7ca9
to
e52877c
Compare
releasenotes/notes/enable-structored-logging-by-default-b6ad86e55b3582be.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up so quickly! I'm not too familiar with the code itself, but I had some questions stemming from some of the comments as compared to the test cases 🙏
releasenotes/notes/enable-structored-logging-by-default-b6ad86e55b3582be.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question, but otherwise lgtm
8441141
to
f0e5806
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 274 ± 3 ms. The average import time from base is: 275 ± 2 ms. The import time difference between this PR and base is: -0.7 ± 0.1 ms. Import time breakdownThe following import paths have appeared:
|
a2e3eec
to
e1060b7
Compare
a95b37d
to
6601361
Compare
e5682a2
to
ea188af
Compare
3023ee8
to
15b3ffb
Compare
_logs_injection
global configuration to determine whether trace info should be injected into a log message. This simplifies remote configuration logic, and provides one central flag that can modify all logging integrations. With this approach we no longer need to unpatch logging integrations.DD_LOGS_ENABLED
toTrue
,False
, and leaving this config unset.Next steps
Checklist
Reviewer Checklist