Skip to content

chore(ci): move the pygoat CI step from hatch to riot #13395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 10, 2025

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented May 13, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux self-assigned this May 13, 2025
@juanjux juanjux requested review from a team as code owners May 13, 2025 08:30
@juanjux juanjux added the changelog/no-changelog A changelog entry is not required for this PR. label May 13, 2025
@juanjux juanjux requested review from a team as code owners May 13, 2025 08:30
@juanjux juanjux added the ASM Application Security Monitoring label May 13, 2025
Copy link
Contributor

github-actions bot commented May 13, 2025

CODEOWNERS have been resolved as:

.riot/requirements/115ddbf.txt                                          @DataDog/apm-python
.riot/requirements/a19438c.txt                                          @DataDog/apm-python
.riot/requirements/d74f3e1.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@juanjux juanjux changed the title move the pygoat CI step from hatch to riot chore(ci): move the pygoat CI step from hatch to riot May 13, 2025
Copy link
Contributor

github-actions bot commented May 13, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 287 ± 5 ms.

The average import time from base is: 289 ± 6 ms.

The import time difference between this PR and base is: -2.1 ± 0.3 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.019 ms (0.70%)
ddtrace.bootstrap.sitecustomize 1.328 ms (0.46%)
ddtrace.bootstrap.preload 1.328 ms (0.46%)
ddtrace.internal.remoteconfig.client 0.660 ms (0.23%)
ddtrace 0.691 ms (0.24%)
ddtrace.internal._unpatched 0.034 ms (0.01%)
json 0.034 ms (0.01%)
json.decoder 0.034 ms (0.01%)
re 0.034 ms (0.01%)
enum 0.034 ms (0.01%)
types 0.034 ms (0.01%)

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-07-10 15:43:30

Comparing candidate commit 62c1584 in PR branch juanjux/iast-integrations-pygoat-to-riot with baseline commit 2d305dd in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 519 metrics, 2 unstable metrics.

scenario:iastaspects-replace_aspect

  • 🟥 execution_time [+715.401ns; +797.587ns] or [+14.987%; +16.709%]

juanjux added 2 commits May 13, 2025 15:19
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux
Copy link
Collaborator Author

juanjux commented May 30, 2025

Closing too many CI mysteries for now.

@juanjux juanjux closed this May 30, 2025
@juanjux juanjux reopened this Jul 10, 2025
@juanjux juanjux added CI and removed backport 2.21 labels Jul 10, 2025
@juanjux juanjux merged commit eef5e42 into main Jul 10, 2025
905 of 909 checks passed
@juanjux juanjux deleted the juanjux/iast-integrations-pygoat-to-riot branch July 10, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants