Skip to content

chore: remove python2 type from debug file #13327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jessicagamio
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@jessicagamio jessicagamio added the changelog/no-changelog A changelog entry is not required for this PR. label May 2, 2025
@jessicagamio jessicagamio requested a review from a team as a code owner May 2, 2025 23:21
@jessicagamio jessicagamio requested a review from juanjux May 2, 2025 23:21
Copy link
Contributor

github-actions bot commented May 2, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/debug.py                                               @DataDog/apm-core-python

@@ -21,7 +21,7 @@


if TYPE_CHECKING: # pragma: no cover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shoukd we able to remove TYPE_CHECKING from this module: https://docs.python.org/3/library/typing.html#typing.TYPE_CHECKING

@github-actions github-actions bot added the stale label Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 7, 2025

This pull request has been automatically closed after a period of inactivity.
After this much time, it will likely be easier to open a new pull request with the
same changes than to update this one from the base branch. Please comment or reopen
if you think this pull request was closed in error.

@github-actions github-actions bot closed this Jun 7, 2025
@mabdinur mabdinur reopened this Aug 5, 2025
@github-actions github-actions bot removed the stale label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants