feat(llmobs): add datasets and experiments features #13314
+151,201
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 235 ± 3 ms. The average import time from base is: 235 ± 3 ms. The import time difference between this PR and base is: -0.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-19 20:06:37 Comparing candidate commit a648fe5 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 507 metrics, 4 unstable metrics. scenario:telemetryaddmetric-flush-1000-metrics
|
Kyle-Verhoog
requested changes
Jun 11, 2025
| if site is None: | ||
| site = os.getenv("DD_SITE") | ||
| if site is None: | ||
| raise ConfigurationError( |
There was a problem hiding this comment.
we say in the docstring that this defaults to "datadoghq.com" but raise here. I think we should default it and not raise here.
| from .utils._exceptions import DatasetFileError | ||
|
|
||
| if TYPE_CHECKING: | ||
| import pandas as pd |
There was a problem hiding this comment.
I think this could interfere with a user's typechecker if they don't have pandas installed when type checking their own app. We should still guard this with a try
| self.add(record) | ||
| return self | ||
|
|
||
| def add(self, record: Dict[str, Union[str, Dict[str, Any]]]) -> None: |
There was a problem hiding this comment.
defining a record type could drastically improve usability here.
class Record(TypedDict):
input: str
expected_output: Dict[str, JsonType]for example
|
|
||
| # Experiments related | ||
| EXPECTED_OUTPUT = "_ml_obs.meta.input.expected_output" | ||
| EXPERIMENT_INPUT = "_ml_obs.meta.input" |
There was a problem hiding this comment.
confused as to why we need new fields for input and output here but maybe it will become obvious from further reading
| @@ -241,6 +253,12 @@ def _llmobs_tags(span: Span, ml_app: str, session_id: Optional[str] = None) -> L | |||
| "language": "python", | |||
| "error": span.error, | |||
| } | |||
|
|
|||
| # Add experiment_id from baggage if present | |||
| experiment_id = span.context.get_baggage_item(EXPERIMENT_ID_BAGGAGE_KEY) | |||
There was a problem hiding this comment.
we should just look generally in the context for the experiment ID to follow the same paradigm we do for parent id and mlobs trace id
There was a problem hiding this comment.
let's separate out this ui code and printing logic to an additional PR. There's too much going on here
docker/.python-version
Outdated
There was a problem hiding this comment.
we should inline these file contents to the tests
| def reset_config_state(): | ||
| """Resets global configuration state before each test.""" | ||
| # Reset global state variables to defaults | ||
| config._IS_INITIALIZED = False |
There was a problem hiding this comment.
these values aren't kept in sync with the defaults, definitely want to move away from the globals
| @pytest.fixture(scope="module", autouse=True) | ||
| def init_llmobs(experiments_vcr): | ||
| # Use the provided keys directly. VCR filtering handles redaction. | ||
| api_key = DD_API_KEY |
There was a problem hiding this comment.
definitely don't want to use globals in the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Add proper description
Checklist
Reviewer Checklist