-
Notifications
You must be signed in to change notification settings - Fork 440
feat(llmobs): [MLOB-2681] instrument openai responses with llm #13310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 274 ± 2 ms. The average import time from base is: 276 ± 2 ms. The import time difference between this PR and base is: -2.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-17 01:58:38 Comparing candidate commit 37aa590 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 563 metrics, 7 unstable metrics. scenario:iastaspects-replace_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
fixing format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits but good to merge once addressed!
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
…trace-py into xinyuan/openai-responses-llm Merge remote changes
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
This PR add LLM tracing/instrumentation for the OpenAI Responses endpoint.
For stream response, we will only get the
response.completed
chunk because it includes all metadata. Since there's only oneresponse
object that is present in each stream chunk, we append it as the first item instreamed_chunks
.This PR only handles function tool, and we might want to support other type of tools (i.e file search) in the furture.
Checklist
Reviewer Checklist