Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): updating DD_TRACE_PROPAGATION_STYLE to include baggage #13078

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

rachelyangdog
Copy link
Contributor

@rachelyangdog rachelyangdog commented Apr 4, 2025

Updating DD_TRACE_PROPAGATION_STYLE description to include baggage

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@rachelyangdog rachelyangdog requested a review from a team as a code owner April 4, 2025 17:39
@rachelyangdog rachelyangdog requested a review from avara1986 April 4, 2025 17:39
Copy link
Contributor

github-actions bot commented Apr 4, 2025

CODEOWNERS have been resolved as:

docs/configuration.rst                                                  @DataDog/python-guild

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 242 ± 6 ms.

The average import time from base is: 243 ± 5 ms.

The import time difference between this PR and base is: -1.3 ± 0.3 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.950 ms (0.81%)
ddtrace.bootstrap.sitecustomize 1.283 ms (0.53%)
ddtrace.bootstrap.preload 1.283 ms (0.53%)
ddtrace.internal.products 1.283 ms (0.53%)
ddtrace.internal.remoteconfig.client 0.632 ms (0.26%)
ddtrace 0.667 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2025

Benchmarks

Benchmark execution time: 2025-04-04 18:27:34

Comparing candidate commit 0e863f5 in PR branch rachel.yang/baggage-update-doc with baseline commit 9a5fd14 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@rachelyangdog rachelyangdog added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 4, 2025
@rachelyangdog rachelyangdog merged commit 7d1cb72 into main Apr 7, 2025
330 of 332 checks passed
@rachelyangdog rachelyangdog deleted the rachel.yang/baggage-update-doc branch April 7, 2025 17:27
chojomok pushed a commit that referenced this pull request Apr 7, 2025
…13078)

Updating DD_TRACE_PROPAGATION_STYLE description to include baggage

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants