-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: log level has no impact on integration error telemetry #13045
base: main
Are you sure you want to change the base?
Conversation
For awareness @bouwkast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a linting rule to prevent the use of logging.Logger
in integrations? We should encourage developers to use the telemetry writer instead.
@mabdinur the linting rule is a great idea, thank you. |
Linting rule is not possible |
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 228 ± 8 ms. The average import time from base is: 231 ± 8 ms. The import time difference between this PR and base is: -3.2 ± 0.3 ms. Import time breakdownThe following import paths have disappeared:
|
Checklist
Reviewer Checklist