Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log level has no impact on integration error telemetry #13045

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dubloom
Copy link
Contributor

@dubloom dubloom commented Apr 3, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@dubloom dubloom requested a review from brettlangdon April 3, 2025 13:23
@dubloom
Copy link
Contributor Author

dubloom commented Apr 3, 2025

For awareness @bouwkast

Copy link
Contributor

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a linting rule to prevent the use of logging.Logger in integrations? We should encourage developers to use the telemetry writer instead.

@dubloom
Copy link
Contributor Author

dubloom commented Apr 3, 2025

@mabdinur the linting rule is a great idea, thank you.

@dubloom
Copy link
Contributor Author

dubloom commented Apr 7, 2025

Linting rule is not possible

Copy link
Contributor

github-actions bot commented Apr 8, 2025

CODEOWNERS have been resolved as:

ddtrace/contrib/dbapi.py                                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/anthropic/_streaming.py                        @DataDog/ml-observability
ddtrace/contrib/internal/asgi/middleware.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/services/bedrock.py                   @DataDog/ml-observability
ddtrace/contrib/internal/botocore/services/kinesis.py                   @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/services/stepfunctions.py             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/botocore/utils.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/cassandra/session.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/coverage/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/django/patch.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/django/utils.py                                @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/elasticsearch/patch.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/flask/patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/flask_cache/patch.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/freezegun/patch.py                             @DataDog/ci-app-libraries
ddtrace/contrib/internal/grpc/aio_client_interceptor.py                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/grpc/client_interceptor.py                     @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/grpc/utils.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/httplib/patch.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/kafka/patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/openai/utils.py                                @DataDog/ml-observability
ddtrace/contrib/internal/pylibmc/client.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pymemcache/client.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pytest/_benchmark_utils.py                     @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_plugin_v1.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_pytest_bdd_subplugin.py                @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_utils.py                               @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest_bdd/_plugin.py                          @DataDog/ci-app-libraries
ddtrace/contrib/internal/requests/connection.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/sanic/patch.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/selenium/patch.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/subprocess/patch.py                            @DataDog/asm-python
ddtrace/contrib/internal/trace_utils.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/unittest/patch.py                              @DataDog/ci-app-libraries
ddtrace/internal/telemetry/writer.py                                    @DataDog/apm-core-python

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 228 ± 8 ms.

The average import time from base is: 231 ± 8 ms.

The import time difference between this PR and base is: -3.2 ± 0.3 ms.

Import time breakdown

The following import paths have disappeared:

ddtrace.auto 0.403 ms (0.18%)
ddtrace 0.403 ms (0.18%)
ddtrace._logger 0.403 ms (0.18%)
ddtrace.internal.telemetry 0.403 ms (0.18%)
ddtrace.internal.telemetry.writer 0.403 ms (0.18%)
ddtrace.internal.telemetry.logging 0.403 ms (0.18%)

The following import paths have grown:

ddtrace.auto 0.333 ms (0.15%)
ddtrace 0.333 ms (0.15%)
ddtrace.settings._config 0.180 ms (0.08%)
ddtrace.internal.gitmetadata 0.180 ms (0.08%)
ddtrace.ext.ci 0.180 ms (0.08%)
ddtrace.ext.git 0.180 ms (0.08%)
shutil 0.071 ms (0.03%)
lzma 0.071 ms (0.03%)
ddtrace._logger 0.153 ms (0.07%)
ddtrace.internal.telemetry 0.153 ms (0.07%)
ddtrace.internal.telemetry.writer 0.153 ms (0.07%)
ddtrace.internal.telemetry.metrics_namespaces 0.085 ms (0.04%)
http.client 0.068 ms (0.03%)
email.parser 0.068 ms (0.03%)
email.feedparser 0.068 ms (0.03%)
email._policybase 0.068 ms (0.03%)
email.header 0.068 ms (0.03%)
email.charset 0.068 ms (0.03%)

The following import paths have shrunk:

ddtrace.auto 2.292 ms (1.00%)
ddtrace.bootstrap.sitecustomize 1.390 ms (0.61%)
ddtrace.bootstrap.preload 1.390 ms (0.61%)
ddtrace.internal.products 1.390 ms (0.61%)
ddtrace.internal.remoteconfig.client 0.686 ms (0.30%)
ddtrace 0.902 ms (0.40%)
ddtrace.settings._config 0.170 ms (0.07%)
ddtrace.internal.gitmetadata 0.170 ms (0.07%)
ddtrace.ext.ci 0.170 ms (0.07%)
ddtrace.ext.git 0.072 ms (0.03%)
shutil 0.072 ms (0.03%)
bz2 0.072 ms (0.03%)
ddtrace._logger 0.073 ms (0.03%)
ddtrace.internal.telemetry 0.073 ms (0.03%)
ddtrace.internal.telemetry.writer 0.073 ms (0.03%)
http.client 0.073 ms (0.03%)
email.parser 0.073 ms (0.03%)
email.feedparser 0.073 ms (0.03%)
email._policybase 0.073 ms (0.03%)
email.header 0.073 ms (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants