Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tracing): make function a span property #13042

Merged
merged 6 commits into from
Apr 10, 2025

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Apr 3, 2025

We turn a utility function into a span property.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We turn a utility function into a span property.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 3, 2025
@P403n1x87 P403n1x87 requested review from a team as code owners April 3, 2025 10:00
@P403n1x87 P403n1x87 added the Tracing Distributed Tracing label Apr 3, 2025
@P403n1x87 P403n1x87 enabled auto-merge (squash) April 3, 2025 10:00
Copy link
Contributor

github-actions bot commented Apr 3, 2025

CODEOWNERS have been resolved as:

ddtrace/_trace/processor/__init__.py                                    @DataDog/apm-sdk-api-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-api-python
ddtrace/internal/processor/stats.py                                     @DataDog/apm-core-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@pr-commenter
Copy link

pr-commenter bot commented Apr 3, 2025

Benchmarks

Benchmark execution time: 2025-04-10 13:06:42

Comparing candidate commit 6e66b30 in PR branch refactor/span-is-top-level-method with baseline commit 9d2d4e6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

CODEOWNERS have been resolved as:

ddtrace/_trace/processor/__init__.py                                    @DataDog/apm-sdk-api-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-api-python
ddtrace/internal/processor/stats.py                                     @DataDog/apm-core-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@P403n1x87 P403n1x87 requested a review from emmettbutler April 4, 2025 11:28
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 230 ± 2 ms.

The average import time from base is: 233 ± 2 ms.

The import time difference between this PR and base is: -2.55 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.034 ms (0.88%)
ddtrace.bootstrap.sitecustomize 1.367 ms (0.59%)
ddtrace.bootstrap.preload 1.367 ms (0.59%)
ddtrace.internal.products 1.367 ms (0.59%)
ddtrace.internal.remoteconfig.client 0.644 ms (0.28%)
ddtrace 0.667 ms (0.29%)

@P403n1x87 P403n1x87 merged commit 5261377 into main Apr 10, 2025
716 checks passed
@P403n1x87 P403n1x87 deleted the refactor/span-is-top-level-method branch April 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Tracing Distributed Tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants