-
Notifications
You must be signed in to change notification settings - Fork 440
refactor(telemetry): add span component to the telemetry metrics #12430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 43.77s Total Time |
BenchmarksBenchmark execution time: 2025-06-06 20:01:10 Comparing candidate commit dd2c178 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 554 metrics, 7 unstable metrics. scenario:iastaspectsospath-ospathjoin_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplit_aspect
|
… Otherwise, default to api. Also, remove the batching aspect to evaluate performance impact since there are more integrations to send than api.
Related to the efforts in #12430. I separated the benchmarks in a separate PR since it doesn't need to be tied up with that PR. The goal of this PR is to add the benchmark measuring the impact of creating instrumentation telemetry metrics. Credits: @erikayasuda and @brettlangdon for pairing with me on this and checking out the results! ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 275 ± 3 ms. The average import time from base is: 281 ± 4 ms. The import time difference between this PR and base is: -5.3 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
There's no way to tell which integrations are in use, so this PR attempts to fix that, some refactoring was done based on the improvements in https://github.com/DataDog/dd-trace-py/pull/12738/files .
Checklist
Reviewer Checklist