-
Notifications
You must be signed in to change notification settings - Fork 450
ci: switch repo to use pytest plugin v2 #11379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch repo to use pytest plugin v2 #11379
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11379 +/- ##
==========================================
- Coverage 13.93% 13.91% -0.02%
==========================================
Files 1520 1530 +10
Lines 131435 132660 +1225
==========================================
+ Hits 18313 18463 +150
- Misses 113122 114197 +1075 ☔ View full report in Codecov by Sentry. |
@christophe-papazian , mind taking a peek at the |
BenchmarksBenchmark execution time: 2024-11-14 17:21:28 Comparing candidate commit 6d139ad in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 387 metrics, 2 unstable metrics. scenario:iast_aspects-ospathnormcase_aspect
|
Datadog ReportBranch report: ✅ 0 Failed, 14 Passed, 1454 Skipped, 1m 3.15s Total duration (35m 44.09s time saved) |
Test output capture was disabled (with the pytest `-s` option) in PR #11379, when the pytest v2 plugin was introduced (I suppose because we wanted to check if the new plugin was behaving properly at the time). This is not needed anymore. This PR removes the `-s` flag. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Test output capture was disabled (with the pytest `-s` option) in PR #11379, when the pytest v2 plugin was introduced (I suppose because we wanted to check if the new plugin was behaving properly at the time). This is not needed anymore. This PR removes the `-s` flag. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
This makes tweaks to run the new version of the
pytest
plugin on thedd-trace-py
repostitory.appsec
suite_CI_DD_ENV
is introduced as a way to override theDD_ENV
from the environment (as setting it in our current CI breaks dozens of unrelated tests)-s
flag is added topytest
invocations for output to appearModuleWatchdog
now has children classes that may be activeChecklist
Reviewer Checklist