Skip to content

Adds opentracing compatibility. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcchavezs merged 4 commits into from
Feb 27, 2018
Merged

Adds opentracing compatibility. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0795580
Adds opentracing compatibility.
jcchavezs Feb 16, 2018
6f16ae0
Adds tests for the propagation.
jcchavezs Feb 16, 2018
dc2f460
Removes logger dependency and fixes dev autoloading.
jcchavezs Feb 16, 2018
d405aaf
Adds improvements based on feedback.
jcchavezs Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"minimum-stability": "dev",
"require": {
"opentracing/opentracing": "1.0.0-beta2",
"symfony/polyfill": "~1.7.0"
"symfony/polyfill": "~1.7.0",
"guzzlehttp/psr7": "^1.4@dev"
},
"require-dev": {
"phpunit/phpunit": "~5.7.19",
Expand Down
22 changes: 22 additions & 0 deletions src/DDTrace/Exceptions/InvalidSpanArgument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

namespace DDTrace\Exceptions;

use InvalidArgumentException;

final class InvalidSpanArgument extends InvalidArgumentException
{
public static function forTagKey($key)
{
return new self(
sprintf('Invalid key type in given span tags. Expected string, got %s.', gettype($key))
);
}

public static function forError($error)
{
return new self(
sprintf('Error should be either Exception or Throwable, got %s.', gettype($error))
);
}
}
Loading