Skip to content

test: backport Phar gzip timing fix for PHP < 7.4 - #4298

Open
realFlowControl wants to merge 1 commit into
masterfrom
florian/fix-phar-gzip-timing
Open

realFlowControl wants to merge 1 commit into
masterfrom
florian/fix-phar-gzip-timing

Conversation

@realFlowControl

@realFlowControl realFlowControl commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Description

Backport PHP's upstream fix for ext/phar/tests/phar_gzip.phpt on PHP < 7.4 in the shared language-test runner.

The original test compares an in-memory entry timestamp with a timestamp written later into the archive. Crossing a second boundary causes a false failure, see CI:

========DIFF========
005+ timestamp changed, was 1791458152, now 1791458153!
========DONE========
FAIL Phar: gzipped phar [ext/phar/tests/phar_gzip.phpt] 

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl
realFlowControl marked this pull request as ready for review October 9, 2026 15:47
@realFlowControl
realFlowControl requested review from a team as code owners October 9, 2026 15:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T15:51:28.667911Z 08b752d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-09T15:51:59.405152Z 08b752d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The backport targets the Phar timestamp comparison responsible for false failures when archive creation crosses a second boundary, with the change gated to PHP versions below 7.4. The static reviewer found no actionable defect.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 08b752d

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.57% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 08b752d | Docs | View more details | Give us feedback!

@bwoebi bwoebi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding it to the xfail lists it would've also worked, but fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants