Repository navigation
test: backport Phar gzip timing fix for PHP < 7.4 - #4298
realFlowControl wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The backport targets the Phar timestamp comparison responsible for false failures when archive creation crosses a second boundary, with the change gated to PHP versions below 7.4. The static reviewer found no actionable defect.
🤖 Bits Code Review · Commit 08b752d
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 08b752d | Docs | View more details | Give us feedback! |
bwoebi
left a comment
There was a problem hiding this comment.
adding it to the xfail lists it would've also worked, but fine.
Description
Backport PHP's upstream fix for
ext/phar/tests/phar_gzip.phpton PHP < 7.4 in the shared language-test runner.The original test compares an in-memory entry timestamp with a timestamp written later into the archive. Crossing a second boundary causes a false failure, see CI:
Reviewer checklist