Skip to content

libdatadog update to a887c164 - #4291

Open
dd-octo-sts[bot] wants to merge 2 commits into
masterfrom
bot/libdatadog-latest
Open

dd-octo-sts[bot] wants to merge 2 commits into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous $LIBDATADOG_PINNED_SHA
New a887c1644be7b7b44829fcf71ed5e6058ae8d67e

Full CI result: ❌ 4 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/144036920


libdatadog Integration Report

libdatadog SHA: a887c1644be7b7b44829fcf71ed5e6058ae8d67e
Analysis date: 2026-10-12

Overall status

✅ Clean update (no API incompatibilities; remaining failures are timeouts /
infra, not attributable to libdatadog, but see caveats below)

Build & test summary

Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/144036920

  • Every compilation job passed in all sub-pipelines (tracer, appsec,
    profiler, shared, package). tmp/artifacts/traces/ is empty: no compile
    failure traces.
  • Sub-pipelines shared-trigger, appsec-trigger and package-trigger
    passed (package passed overall because the failing job below was
    retried/allowed).
  • 4 jobs failed even after retries:
Sub-pipeline Job Failure reason Duration
profiler PHP language tests: [7.3, amd64, zts] job_execution_timeout 3602 s (60 min limit)
profiler PHP language tests: [7.3, amd64, nts] job_execution_timeout 3602 s (60 min limit)
tracer PHP Language Tests: [7.1] job_execution_timeout 2882 s (48 min limit)
package publish docker image for system tests script_failure 275 s

retried_jobs.tsv also lists PHP language tests: [7.2, amd64, nts]
(profiler). It timed out at first and passed on retry, which shows these jobs
run close to their time limit.

The libdatadog delta is small

The changelog artifact goes back a long way, but the pin actually moved only
from 45968e56d to a887c1644, which is 7 commits:

a887c1644 fix: most doc warnings - semantic changes (#2547)
1ea83bc75 fix(gotter): Preserve GOT page permissions (#2635)
7032fc62f feat(data-pipeline): mark native trace exports with _dd.sdk.otlp_export (#2636)
7857308d8 feat(telemetry): Support fork identity updates (#2611)
f52ab62fd fix: most doc warnings (#2289)
7331b536a chore(version): bump to v45.0.0 (#2623)
ed0def30d perf(sampling): remove hot-path allocations in the sample decision (#2646)

(git ls-tree HEAD~1 libdatadog → 45968e56d…; the diff is 80 files, +1306/−219.
Most of it is doc comments and new tests.)

Non-trivial changes made

No code changes required.

Identified libdatadog issues

None identified.

Flaky / ignored failures

Profiler PHP language tests: [7.3, amd64, {nts,zts}]: timeout

These are probably not caused by libdatadog:

  • The job builds with --disable-ddtrace-tracer --enable-ddtrace-profiling.
    No sidecar, telemetry, sampling or crashtracker code is loaded.
  • It sets DD_PROFILING_OUTPUT_PPROF=/tmp/. With that set, the uploader
    (profiling/src/profiler/uploader.rs, run()) writes profiles to disk and
    never calls ProfileExporter/HTTP. The only libdatadog code exercised is
    profile building/serialization in libdd-profiling.
  • The whole libdd-profiling diff in this update is 12 lines, all doc
    comments (git diff 45968e56d HEAD -- libdd-profiling). There are no
    runtime changes.
  • The 7.2 nts job of the same matrix timed out once and passed on retry,
    which fits a job running near its 60-minute limit.
  • The branch also contains the recent large dd-trace-php profiler change
    d55ca28aa fix(profiling): globals init and shutdown (#4296) (15 files,
    +884/−677). If this timeout reproduces on master, look there, not at
    libdatadog.

Tracer PHP Language Tests: [7.1]: timeout

  • .gitlab/generate-tracer.php gives PHP < 7.4 only 1 CPU. PHP < 7.2 keeps
    telemetry enabled, and the config already says: "PHP lt 7.2 have telemetry
    enabled, hit too many job timeouts at 40 mins"
    (raised to 48 min). This job
    is known to run close to its limit.
  • The libdatadog changes that reach the tracer at runtime are minor:
    • libdd-telemetry: the worker's reset() (fork-child path) and session
      headers now read from mutable metadata. reset() runs only after a fork
      inside libdatadog's shared runtime, not on the sidecar's telemetry path.
    • libdd-sampling: an allocation-removal performance change. It is not a
      dependency of the PHP tracer (it does not appear in sidecar/Cargo.toml).
    • libdd-gotter (used by the crashtracker's __assert_fail hook at
      init): PageProtGuard is now created lazily for each library that
      contains a matching relocation, instead of once per pass. Each creation
      reads /proc/self/maps, so a few extra reads happen once per process at
      crashtracker init. That is a negligible cost per process and cannot cause
      a hang.
  • None of these plausibly turns a test into a hang. It looks like the known
    slow job, not a regression.

publish docker image for system tests: script failure

This is a docker build/push step on the microVM runner that failed after
275 s. It is unrelated to libdatadog APIs (the build itself compiled), and
the package-trigger sub-pipeline ended as success. Treat it as infra.

Caveats / verification limits

  • I could not get the job logs: the GitLab API returned HTTP 401 with the job
    token. Only the job metadata (failure reasons, durations) was available, so
    I don't know which test each language-test job was running when it timed
    out.
  • I could not build or run tests in this environment, so I did not check the
    merge-base (d55ca28aa) for the same timeouts. GitHub reports the master
    pipeline for d55ca28aa as failed too, but job-level details were not
    available.
  • Recommended follow-up: re-run the three language-test jobs. If the
    profiler 7.3 jobs keep timing out, run the same job on master (d55ca28aa,
    same profiler code, previous libdatadog pin) to confirm it is
    independent of libdatadog. Then check the per-test durations in the JUnit
    artifact (artifacts/tests/php-tests.xml).

/cc @bwoebi

@dd-octo-sts
dd-octo-sts Bot requested review from a team as code owners October 8, 2026 06:52
@dd-octo-sts
dd-octo-sts Bot requested review from danyal002 and sameerank and removed request for a team October 8, 2026 06:52
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 7 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.1]

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | PHP language tests: [7.2, amd64, zts]

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | PHP language tests: [7.3, amd64, nts]

View more details · View in GitLab

View all 7 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.57% (-0.04%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 25ec9c6 | Docs | View more details | Give us feedback!

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 45968e56 libdatadog update to a887c164 Oct 9, 2026
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 3 times, most recently from 3244d44 to e9587de Compare October 11, 2026 06:21
@dd-octo-sts
dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 55c0d82 to d9eaf0c Compare October 12, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants