Repository navigation
libdatadog update to a887c164 - #4291
Open
dd-octo-sts[bot] wants to merge 2 commits into
Open
dd-octo-sts[bot] wants to merge 2 commits into
dd-octo-sts[bot] wants to merge 2 commits into
Conversation
dd-octo-sts
Bot
requested review from
danyal002 and
sameerank
and removed request for
a team
October 8, 2026 06:52
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 7 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 25ec9c6 | Docs | View more details | Give us feedback! |
dd-octo-sts
Bot
force-pushed
the
bot/libdatadog-latest
branch
3 times, most recently
from
October 11, 2026 06:21
3244d44 to
e9587de
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/144006642 Full CI result: ❌ 7 job(s) failed
dd-octo-sts
Bot
force-pushed
the
bot/libdatadog-latest
branch
from
October 12, 2026 06:15
55c0d82 to
d9eaf0c
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/144036920 Full CI result: ❌ 4 job(s) failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated update of the libdatadog submodule to the latest HEAD.
$LIBDATADOG_PINNED_SHAa887c1644be7b7b44829fcf71ed5e6058ae8d67eFull CI result: ❌ 4 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/144036920
libdatadog Integration Report
libdatadog SHA: a887c1644be7b7b44829fcf71ed5e6058ae8d67e
Analysis date: 2026-10-12
Overall status
✅ Clean update (no API incompatibilities; remaining failures are timeouts /
infra, not attributable to libdatadog, but see caveats below)
Build & test summary
Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/144036920
profiler, shared, package).
tmp/artifacts/traces/is empty: no compilefailure traces.
shared-trigger,appsec-triggerandpackage-triggerpassed (package passed overall because the failing job below was
retried/allowed).
job_execution_timeoutjob_execution_timeoutjob_execution_timeoutscript_failureretried_jobs.tsvalso listsPHP language tests: [7.2, amd64, nts](profiler). It timed out at first and passed on retry, which shows these jobs
run close to their time limit.
The libdatadog delta is small
The changelog artifact goes back a long way, but the pin actually moved only
from
45968e56dtoa887c1644, which is 7 commits:(
git ls-tree HEAD~1 libdatadog→45968e56d…; the diff is 80 files, +1306/−219.Most of it is doc comments and new tests.)
Non-trivial changes made
No code changes required.
Identified libdatadog issues
None identified.
Flaky / ignored failures
Profiler
PHP language tests: [7.3, amd64, {nts,zts}]: timeoutThese are probably not caused by libdatadog:
--disable-ddtrace-tracer --enable-ddtrace-profiling.No sidecar, telemetry, sampling or crashtracker code is loaded.
DD_PROFILING_OUTPUT_PPROF=/tmp/. With that set, the uploader(
profiling/src/profiler/uploader.rs,run()) writes profiles to disk andnever calls
ProfileExporter/HTTP. The only libdatadog code exercised isprofile building/serialization in
libdd-profiling.libdd-profilingdiff in this update is 12 lines, all doccomments (
git diff 45968e56d HEAD -- libdd-profiling). There are noruntime changes.
which fits a job running near its 60-minute limit.
d55ca28aa fix(profiling): globals init and shutdown (#4296)(15 files,+884/−677). If this timeout reproduces on master, look there, not at
libdatadog.
Tracer
PHP Language Tests: [7.1]: timeout.gitlab/generate-tracer.phpgives PHP < 7.4 only 1 CPU. PHP < 7.2 keepstelemetry enabled, and the config already says: "PHP lt 7.2 have telemetry
enabled, hit too many job timeouts at 40 mins" (raised to 48 min). This job
is known to run close to its limit.
libdd-telemetry: the worker'sreset()(fork-child path) and sessionheaders now read from mutable metadata.
reset()runs only after a forkinside libdatadog's shared runtime, not on the sidecar's telemetry path.
libdd-sampling: an allocation-removal performance change. It is not adependency of the PHP tracer (it does not appear in
sidecar/Cargo.toml).libdd-gotter(used by the crashtracker's__assert_failhook atinit):
PageProtGuardis now created lazily for each library thatcontains a matching relocation, instead of once per pass. Each creation
reads
/proc/self/maps, so a few extra reads happen once per process atcrashtracker init. That is a negligible cost per process and cannot cause
a hang.
slow job, not a regression.
publish docker image for system tests: script failureThis is a docker build/push step on the microVM runner that failed after
275 s. It is unrelated to libdatadog APIs (the build itself compiled), and
the
package-triggersub-pipeline ended as success. Treat it as infra.Caveats / verification limits
token. Only the job metadata (failure reasons, durations) was available, so
I don't know which test each language-test job was running when it timed
out.
merge-base (
d55ca28aa) for the same timeouts. GitHub reports the masterpipeline for
d55ca28aaas failed too, but job-level details were notavailable.
profiler 7.3 jobs keep timing out, run the same job on master (
d55ca28aa,same profiler code, previous libdatadog pin) to confirm it is
independent of libdatadog. Then check the per-test durations in the JUnit
artifact (
artifacts/tests/php-tests.xml)./cc @bwoebi